Date: Sat, 25 Mar 2023 10:45:46 GMT From: Dmitry Chagin <dchagin@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 1f0c8bfd6504 - main - linsysfs(4): Keep Linux compatible sysfs the same as Ubuntu Message-ID: <202303251045.32PAjkZP053879@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=1f0c8bfd650422a30aa6fcf01da860b8d43628a8 commit 1f0c8bfd650422a30aa6fcf01da860b8d43628a8 Author: Vico Chen <vico.chern_qq.com> AuthorDate: 2023-03-25 10:41:04 +0000 Commit: Dmitry Chagin <dchagin@FreeBSD.org> CommitDate: 2023-03-25 10:41:04 +0000 linsysfs(4): Keep Linux compatible sysfs the same as Ubuntu By checking Ubuntu, there is no `/sys/subsystem' in sysfs. To compatible with Ubuntu, delete the 'subsystem' creation in Linux compatible module. On the other hand, the sysfs `/sys/subsystem' cause failure for some Linux udev cases. In Linux udev source code, there is a function named `scan_devices_all', and it will scan `/sys/subsystem' if it is existed, but now there are nothing in /sys/subsystem `, and it returns empty to cause some use cases failed. Reviewed by: dchagin Differential Revision: https://reviews.freebsd.org/D38885 MFC after: 1 month XMFC with: ifAPI --- sys/compat/linsysfs/linsysfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/compat/linsysfs/linsysfs.c b/sys/compat/linsysfs/linsysfs.c index 298ce4508b4d..23abd2c32743 100644 --- a/sys/compat/linsysfs/linsysfs.c +++ b/sys/compat/linsysfs/linsysfs.c @@ -535,9 +535,6 @@ linsysfs_init(PFS_INIT_ARGS) /* /sys/kernel/debug, mountpoint for lindebugfs. */ pfs_create_dir(kernel, "debug", NULL, NULL, NULL, 0); - /* /sys/subsystem/... */ - dir = pfs_create_dir(root, "subsystem", NULL, NULL, NULL, 0); - linsysfs_net_init(); return (0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303251045.32PAjkZP053879>