Date: Thu, 28 Nov 2019 11:31:13 -0800 From: Craig Leres <leres@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518273 - head/comms/conserver-com Message-ID: <85ceb4a8-9df7-0a58-c5e0-6f144c0736a6@freebsd.org> In-Reply-To: <20191125063709.GC84936@FreeBSD.org> References: <201911232108.xANL825f004203@repo.freebsd.org> <20191123213729.3taj4chqdoc6vsyb@atuin.in.mat.cc> <af0d9e45-64d9-1290-3add-9b5c479940af@freebsd.org> <20191125063709.GC84936@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/24/2019 10:37 PM, Alexey Dokuchaev wrote: > On Sat, Nov 23, 2019 at 01:43:27PM -0800, Craig Leres wrote: >> On 2019-11-23 13:37, Mathieu Arnold wrote: >>> On Sat, Nov 23, 2019 at 09:08:02PM +0000, Craig Leres wrote: >>>> New Revision: 518273 >>>> URL:https://svnweb.freebsd.org/changeset/ports/518273 >>>> >>>> Log: >>>> comms/conserver-com: Update distinfo and remove BROKEN >>> This seems to be missing the description of the changes between the two >>> distribution files. >> >> Sorry. "Apparently github occasionally changes their software resulting >> in a change in the tarchive checksum. Update to reflect the current >> version." > > The thing is, you are expected to obtain both versions of the distfile > and compare them, explicitly asserting in the commit log that there were > no malicious changes introduced (and it they were, notify the upstream, > other distros' package maintainers, users, and general public immediately). > > This is documented in the PHB Section 13.18. When this happened, I downloaded the new tarchive and unpacked both and did a diff -r on them; the files were identical. It looked like the same files packaged in a different order. I understand now that this should have gone in the commit message. Craig
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?85ceb4a8-9df7-0a58-c5e0-6f144c0736a6>