Date: Sun, 28 Jul 2013 12:09:34 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Tim Kientzle <kientzle@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r323836 - in head/devel: . arm-eabi-binutils arm-eabi-binutils/files Message-ID: <CAMuy=%2BhFpUQRRkOgi0KEktqpFyNyX=6OTyP5rmSEsGqWo4A85w@mail.gmail.com> In-Reply-To: <201307281645.r6SGjNAs020031@svn.freebsd.org> References: <201307281645.r6SGjNAs020031@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 28, 2013 at 9:45 AM, Tim Kientzle <kientzle@freebsd.org> wrote: > Author: kientzle (src committer) > Date: Sun Jul 28 16:45:22 2013 > New Revision: 323836 > URL: http://svnweb.freebsd.org/changeset/ports/323836 > > Log: > Add arm-eabi-binutils cross-tools. > > Approved by: db > > Added: head/devel/arm-eabi-binutils/Makefile > > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/arm-eabi-binutils/Makefile Sun Jul 28 16:45:22 2013 > (r323836) > @@ -0,0 +1,47 @@ > +# $FreeBSD$ > + > +PORTNAME= binutils > +PORTVERSION= 2.23.2 > +CATEGORIES= devel > +MASTER_SITES= ${MASTER_SITE_SOURCEWARE} > +MASTER_SITE_SUBDIR= binutils/releases > +PKGNAMEPREFIX= arm-eabi- > + > +MAINTAINER= kientzle@gmail.com > +COMMENT= GNU binutils for vanilla ARM cross-development > + > +.if !defined(WITHOUT_NLS) > +USE_GETTEXT= yes > +PLIST_SUB+= NLS="" > +.else > +CONFIGURE_ARGS+= --disable-nls > +PLIST_SUB+= NLS="@comment " > +.endif > +USE_BZIP2= yes > +USE_GMAKE= yes > +USES= gettext > +GNU_CONFIGURE= yes > > Is there any particular reason that bsd.port.options.mk wasn't included here? USE_GETTEXT is deprecated, and should be using the USES framework to bring in the dependency. The only reason this dependency is working is that it is unconditionally brought in with the USES framework later in the Makefile. To this affect, if NLS is disabled, it brings in gettext dependency. Can it be disabled? USE_GMAKE can be converted, as well, to the USES framework. (USES= gmake) .include <bsd.port.options.mk> .if ${PORT_OPTIONS:MNLS} USES+= gettext ... .endif Regardless, as always, thank you so much for your time and effort to work and get this inclusion into the tree, as I am sure many will benefit from it. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serv
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2BhFpUQRRkOgi0KEktqpFyNyX=6OTyP5rmSEsGqWo4A85w>