Date: Thu, 7 Aug 2025 23:41:46 -0700 From: Rick Macklem <rick.macklem@gmail.com> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: Rick Macklem <rmacklem@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e3ac01e18eb3 - main - kgssapi: Fix the kgssapi so that it can use MIT Kerberos Message-ID: <CAM5tNy7fic_i_vvacmTV8mOwF_c%2BAWqJ8tN9BcO0kgzhZUjQiQ@mail.gmail.com> In-Reply-To: <CAJ5_RoAh4UACqTJ1GseaVN2NsR3_U5RRQr3WKEQ5p94H_x-0bw@mail.gmail.com> References: <202508072105.577L5nA0081105@gitrepo.freebsd.org> <CAJ5_RoAh4UACqTJ1GseaVN2NsR3_U5RRQr3WKEQ5p94H_x-0bw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 7, 2025 at 9:59 PM Benjamin Kaduk <bjkfbsd@gmail.com> wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@uoguelph.ca.
>
> On Thu, Aug 7, 2025 at 2:07 PM Rick Macklem <rmacklem@freebsd.org> wrote:
>>
>> +enum krb_imp {
>> + KRBIMP_UNKNOWN,
>> + KRBIMP_HESIOD1,
>> + KRBIMP_MIT
>> +};
>>
>
>
>
> I only skimmed the diff so far, but I don't think KRBIMP_HESIOD1 makes much sense as a name -- Hesiod is a directory service of sorts that came out of MIT's Project Athena (it uses the "HS" DNS record class and we have an implementation of its functionality in libc) but is otherwise unrelated to Kerberos. Presumably you wanted something Heimdal-ish here?
Duh. Yes. I once used Hesiod, but I have no idea why I typed that
instead of Heimdal. (It was meant to refer to the older Heimdal, up to 1.5.)
As I recall, the value is ever used in the current code, since it always
tests for it being UNKNOWN, to acquire it and if it is MIT after that,
but I can commit a name change.
rick
>
> -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAM5tNy7fic_i_vvacmTV8mOwF_c%2BAWqJ8tN9BcO0kgzhZUjQiQ>