Date: Fri, 23 Jan 2015 11:05:37 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r377696 - head/Mk/Scripts Message-ID: <54C27F61.7020606@FreeBSD.org> In-Reply-To: <20150123071820.GB70500@FreeBSD.org> References: <201501222105.t0ML5q3U010699@svn.freebsd.org> <20150123071820.GB70500@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/23/2015 1:18 AM, Alexey Dokuchaev wrote: > On Thu, Jan 22, 2015 at 09:05:52PM +0000, Bryan Drewery wrote: >> New Revision: 377696 >> URL: https://svnweb.freebsd.org/changeset/ports/377696 >> QAT: https://qat.redports.org/buildarchive/r377696/ >> >> Log: >> Don't replace PREFIX anywhere in the plist line, only do it for the >> beginning. >> [...] >> - sed_files_gen=3D"s!${PREFIX}/!!g; ${sed_plist_sub} \ >> + sed_files_gen=3D"s!^${PREFIX}/!!g; ${sed_plist_sub} \ >=20 > So why global modifiers are being used? (TBH, they are being abused a = lot > in ports. It seems that folks just throw them in by default without gi= ving > it much thinking.) >=20 > ./danfe >=20 I missed that, will review to see why it was there. --=20 Regards, Bryan Drewery --424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUwn9hAAoJEDXXcbtuRpfPrDcIAM0DVdT40oJTLYEPFoNzkjsi u99DeTXNptDgxbVJSwtSljEkaTUQCBvKzCM2lyJRJj3EV9tE9Wj5p8objFNaNzUl dR3SOHgoUjOMdbbq8BAPqyEp7z8XvDp4cxnQbSR5YL86yw3OT0io9t8MrD577Hxl Bkk18S/R+3hfO6tRx0H6kXgu8LhBC5i6V24vxhpuMJzyMFKGyS14q4KmjgeTYNCD ZVyZh1s1qvxb1a28MwEnqJbalmsAw9Hlkhvnc4NP23j9JuiuRE1KmhTinU0ASnyn LG7LNiayp0Hp+1Gap3U/K8bt4OObrxkcUQrp3x4jClYrsO6l29KmMaoNqkFHdEg= =4n9I -----END PGP SIGNATURE----- --424mn0FSHSONgSkIoi3JQugBK8LLc3Kbn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54C27F61.7020606>