Date: Sat, 10 Nov 2012 13:24:08 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: ZFS can't delete files when over quota Message-ID: <CAGH67wTJmuy_%2BTLxPQpZd%2Buvh5OtrX4XSy=GuiXfXE-PPAbefA@mail.gmail.com> In-Reply-To: <20121110210317.GC19081@dft-labs.eu> References: <509E79C7.10300@shatow.net> <CADLo83-mZ0v=zXJnHF01%2BtOvCtBWtrOTZpcd-V%2BWTF7qXNMJUg@mail.gmail.com> <CAFMmRNx2Xqo%2B3FZ6cT%2Ben-u26SVAecN%2B9ULfoV==fXRRTG7fDg@mail.gmail.com> <CADLo83_wEvUtYDgzoCoE4oNF7j3AMWe-AX6OvpxM12xd5AzJ7w@mail.gmail.com> <509EA942.9060801@shatow.net> <20121110194759.GA19081@dft-labs.eu> <CAGH67wTbGy2FyB91KrCA4aceVQ-BaCzoTA00vNG%2BKGf5LfVBtg@mail.gmail.com> <20121110210317.GC19081@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 10, 2012 at 1:03 PM, Mateusz Guzik <mjguzik@gmail.com> wrote: > On Sat, Nov 10, 2012 at 11:55:14AM -0800, Garrett Cooper wrote: > > On Sat, Nov 10, 2012 at 11:48 AM, Mateusz Guzik <mjguzik@gmail.com> > wrote: > > > > > On Sat, Nov 10, 2012 at 01:21:38PM -0600, Bryan Drewery wrote: > > > > On 11/10/2012 12:55 PM, Chris Rees wrote: > > > > > Bryan, > > > > > > > > > > Please try the patch at [1]; if it works I'll document it. > > > > > > > > > > Chris > > > > > > > > > > [1] http://www.bayofrum.net/~crees/patches/bdrewery.diff > > > > > > > > > > > > > Hmm, I'm not a fan of -T. I think it should just work out-of-the-box > > > here. > > > > > > > > Something like: > > > > > > > > http://people.freebsd.org/~bdrewery/rm-quota.txt > > > > > > > > > > I think this approach is incorrect. > > > > > > If you cannot rm $file due to EDQUOT, but truncate $file && rm $file > > > works (and both patches try to do this), then I think this is a > filesystem > > > bug. > > > > > > > Perhaps. This is kind of an implementation/compatibility issue because of > > how ZFS (and other COW-based FSes) work. > > Except this is not about being unable to rm because of EDQUOT (whether > ZFS can do something about that or not I have no idea). This is about being > able to remove just after truncation, which clearly shows that zfs can in > principle remove this file on its own. > You're probably right. My guess is that the fix would be to ignore EDQUOT in the unlink VOP handler. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wTJmuy_%2BTLxPQpZd%2Buvh5OtrX4XSy=GuiXfXE-PPAbefA>