Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 10 Jul 2018 06:47:02 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 229664] src/sys/netinet/tcp_stacks/rack.c: 2 * poor error checking ?
Message-ID:  <bug-229664-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229664

            Bug ID: 229664
           Summary: src/sys/netinet/tcp_stacks/rack.c: 2 * poor error
                    checking ?
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

1.

src/sys/netinet/tcp_stacks/rack.c:7125]: (style) Unsigned variable 'sb_offs=
et'
can't be negative so it is unnecessary to test it.

Source code is

        KASSERT(sb_offset >=3D 0, ("%s: sack block to the left of una : %d",
                    __func__, sb_offset));

if sb_offset can be negative, then using an unsigned type for it=20
looks wrong. Suggest use signed type.

2.

src/sys/netinet/tcp_stacks/rack.c:7172]: (style) Unsigned variable 'sb_offs=
et'
can't be negative so it is unnecessary to test it.

Duplicate.

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229664-227>