Date: Mon, 30 Jun 2014 17:06:58 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r268028 - head/sys/dev/e1000 Message-ID: <20140630150658.GA4742@onelab2.iet.unipi.it> In-Reply-To: <CA%2BhQ2%2BgOPS6XKeWSNXO2BVkpk%2B82tjvSZ_nWgpwsFgPpEo%2BeNg@mail.gmail.com> References: <201406300434.s5U4YxGY043870@svn.freebsd.org> <CAJ-Vmom7fsk67Q6sWgwu=GOOn59Zu5uGXeNG%2BYt2hP-edN%2BpvQ@mail.gmail.com> <CA%2BhQ2%2BgOPS6XKeWSNXO2BVkpk%2B82tjvSZ_nWgpwsFgPpEo%2BeNg@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Mon, Jun 30, 2014 at 04:56:01PM +0200, Luigi Rizzo wrote:
> I am getting the following error while compiling with gcc:
>
> cc1: warnings being treated as errors
> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c: In function
> 'igb_attach':
> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: warning: 'cpu_id'
> may be used uninitialized in this function
> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: note: 'cpu_id'
> was declared here
>
> (the code is correct, apparently gcc cannot understand that).
>
> For compatibility i'd throw in an explicit initialization,
> however it might be worthwhile rewriting the code with a single
> if (adapter->num_queues > 1) { ...} block within the for(),
> and also using only one #ifdef RSS -- the other places only
> differ in the string passed to diagnostics or comments.
and the same goes for the recent changes to ixgbe.c
cheers
luigi
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140630150658.GA4742>