Date: Sun, 07 Sep 2014 19:14:55 -0700 From: Peter Wemm <peter@wemm.org> To: Alan Cox <alc@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271243 - head/sys/vm Message-ID: <5093630.OkGduFpJtx@overcee.wemm.org> In-Reply-To: <201409080019.s880J4c8002174@svn.freebsd.org> References: <201409080019.s880J4c8002174@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Monday, September 08, 2014 12:19:04 AM Alan Cox wrote:
> Log:
> Make two functions static and eliminate an unused #define.
Unfortunately, the code (and compiler) disagrees..
> @@ -1504,7 +1507,7 @@ again:
> * possibly extended). When merging, this routine may delete one or
> * both neighbors.
> */
> -void
> +static void
> vm_map_simplify_entry(vm_map_t map, vm_map_entry_t entry)
> {
> vm_map_entry_t next, prev;
sys/security/mac/mac_process.c:366:4: error: implicit declaration of function
'vm_map_simplify_entry' is invalid in C99 [-Werror,-Wimplicit-function-
declaration]
vm_map_simplify_entry(map, vme);
The code in question:
static void
mac_proc_vm_revoke_recurse(struct thread *td, struct ucred *cred,
struct vm_map *map)
{
vm_map_entry_t vme;
...
vm_map_simplify_entry(map, vme);
^^^^^^^^^^^^^^^^^^^^^^
}
}
vm_map_unlock(map);
}
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV
UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAABAgAGBQJUDREkAAoJEDXWlwnsgJ4EjoMH+wbDu7i0CVihaUINZxFVDxH3
H+lV2+w+gGThAgpCVnZJCBOleCOzm4ffS13tXXd55lqqXpln0/UjXVi67coZoNql
eELUMhIUD74VDaEVbMbj1uWzRPWYXhw2jEfvFPA01SN0UVN/gBiS5n+vTXcizLJq
Z2UL74gLFdlk6UoOEKkpWya1cnKoS+hvMe5epMntyt0oQ4GHurEEL6a8zyYbtV39
VhWN0NrXe1t/wfpVHVgbp7uxnxd9rtHk4jLtCK+gkMwsdf+p9VklvQ5fsuw3orKm
zd8QE4fp1w3PTWgkzmPtVswXKgRQrj9ybbwj7ytxSVE8x1XJsppYy+7f9GPpino=
=eD0W
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5093630.OkGduFpJtx>