Date: Thu, 17 Mar 2022 22:19:49 +0300 From: Yuri <yuri@aetern.org> To: Mateusz Piotrowski <0mp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7846554819d3 - main - rc.d: Chmod +x all the scripts for consistency Message-ID: <1452d0da-2e76-ad87-097c-106c232bda10@aetern.org> In-Reply-To: <202203171912.22HJCsfE035672@gitrepo.freebsd.org> References: <202203171912.22HJCsfE035672@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mateusz Piotrowski wrote: > The branch main has been updated by 0mp (doc, ports committer): > > URL: https://cgit.FreeBSD.org/src/commit/?id=7846554819d3be52816ca6ad60bf84f6409a0bf1 > > commit 7846554819d3be52816ca6ad60bf84f6409a0bf1 > Author: Mateusz Piotrowski <0mp@FreeBSD.org> > AuthorDate: 2022-03-17 16:20:57 +0000 > Commit: Mateusz Piotrowski <0mp@FreeBSD.org> > CommitDate: 2022-03-17 19:12:04 +0000 > > rc.d: Chmod +x all the scripts for consistency > > Reviewed by: lwhsu > Approved by: lwhsu (src) > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D34589 > --- > libexec/rc/rc.d/auditdistd | 0 > libexec/rc/rc.d/automount | 0 > libexec/rc/rc.d/automountd | 0 > libexec/rc/rc.d/autounmountd | 0 > libexec/rc/rc.d/blacklistd | 0 > libexec/rc/rc.d/ggated | 0 > libexec/rc/rc.d/iovctl | 0 > libexec/rc/rc.d/zfsd | 0 > 8 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/libexec/rc/rc.d/auditdistd b/libexec/rc/rc.d/auditdistd > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/automount b/libexec/rc/rc.d/automount > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/automountd b/libexec/rc/rc.d/automountd > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/autounmountd b/libexec/rc/rc.d/autounmountd > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/blacklistd b/libexec/rc/rc.d/blacklistd > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/ggated b/libexec/rc/rc.d/ggated > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/iovctl b/libexec/rc/rc.d/iovctl > old mode 100644 > new mode 100755 > diff --git a/libexec/rc/rc.d/zfsd b/libexec/rc/rc.d/zfsd > old mode 100644 > new mode 100755 It would seem more logical to change the other ones' mode to 644 instead -- these are the "source" files and are not run during build, so there's no need for them to have execute bit set. More so, the mode gets set to BINMODE on installed files, and it's 555, not 755.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1452d0da-2e76-ad87-097c-106c232bda10>