Date: Thu, 19 Jan 2017 23:31:56 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Xin Li <delphij@delphij.net> Cc: Xin LI <delphij@FreeBSD.org>, d@delphij.net, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312519 - head/usr.bin/sed Message-ID: <FC0FB496-DBF0-4052-9327-7C55E858271C@gmail.com> In-Reply-To: <0cf8edf5-ec3d-e6f1-9d55-1e286014d8f1@delphij.net> References: <201701200645.v0K6j6EK078906@repo.freebsd.org> <35562B6D-E733-4CC8-97C0-81CC8EAC87A7@gmail.com> <0cf8edf5-ec3d-e6f1-9d55-1e286014d8f1@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jan 19, 2017, at 23:27, Xin Li <delphij@delphij.net> wrote: > > > > On 1/19/17 23:13, Ngie Cooper (yaneurabeya) wrote: >> >>> On Jan 19, 2017, at 22:45, Xin LI <delphij@FreeBSD.org> wrote: >>> >>> Author: delphij >>> Date: Fri Jan 20 06:45:06 2017 >>> New Revision: 312519 >>> URL: https://svnweb.freebsd.org/changeset/base/312519 >>> >>> Log: >>> Revert r312404 as we need to do an exp-run and fix existing ports that >>> rely on the previous behavior. >>> >>> Requested by: antonie (portmgr) >> >> I added 2 testcases to help check for this behavior later in r312521. All that needs to be done is remove this line: https://svnweb.freebsd.org/base/head/usr.bin/sed/tests/sed2_test.sh?view=markup&pathrev=312521#l50 . > > Hmm to be honest I believe the old behavior is wrong and the intent is > to reinstate the revision after we have fixed the ports. I agree — once the revision is fixed and committed, it will verify that sed again fails. If that’s not correct per the designed fix, we can modify the testcase further. Thanks :), -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYgbzsAAoJEPWDqSZpMIYVBGMQALJFA2i5OOMNu9BHWmsepOX3 XWxUl/CwX5e9FdtOJxNMxhxKvOrQ7THGmY3LVeLbza7DlKfzSevlecl8vtFQpop6 N7LjH+J1TW+laQBK7JTAZgTSkkTLDSh09QW0z2De8eajKyOchpPTy6WcA4s/A1JF UsPsOXQh9d+ECeX0DR+EPccJgzrQ19BsnJzIZ/i+EgsrjZYiMZe5KYYPpvNYy746 2HJm5dP5aPJKjtd5PkXWa2vo/F9jlPkAIPax0rhxV39w638AVJvcIgBsnxPckNlr bgd0aifWscW9cTZf8aoQR9Ddvwtfb7fvmZDgTNAVunWh0+aYm/tj49q0Ia+8a9y2 jez6DoX0PU61dk0AbiiLYusqZHK0LWdqWNQzE3SzM3gOLSSdMnOKO2IBoYWJZgwh OBY5aJCUQ+/r22RyZO3A8whCzBk+oFPfExq9SXLlUsrrZPd9kAzKTn5RE7TPDkKb QtxAmX53Tdsb3BeQmK3LuuZ0J8WK5CJs9Utt42fVFqLU3eXQHOAIKWxW4f0as4QD sdGXky9lTmrRdt3ifCgMsSPyLwJQ/5vJ46YwitmcnFCA+Y+8sWJ3sXVhATn/1MQp +x+fEIL4yVI+VE2JcS3vxhzUvwzXmUMn4Wa5VBIWmBtGO4V+UK/6qW4byGoW/Grk sSE7jjJ3mTGLGZUn3d5M =2aK/ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FC0FB496-DBF0-4052-9327-7C55E858271C>