Date: Fri, 20 Oct 2023 01:28:10 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 02320f642095 - main - pmap: Prefer consistent naming for loader tunable Message-ID: <07922B4A-923A-41A3-8134-10BAF338564B@FreeBSD.org> In-Reply-To: <202310191701.39JH1UXB041167@gitrepo.freebsd.org> References: <202310191701.39JH1UXB041167@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 20, 2023, at 1:01 AM, Zhenlei Huang <zlei@FreeBSD.org> wrote: >=20 > The branch main has been updated by zlei: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D02320f64209563e35fa371fc5eac9406= 7f688f7f >=20 > commit 02320f64209563e35fa371fc5eac94067f688f7f > Author: Zhenlei Huang <zlei@FreeBSD.org> > AuthorDate: 2023-10-19 17:00:31 +0000 > Commit: Zhenlei Huang <zlei@FreeBSD.org> > CommitDate: 2023-10-19 17:00:31 +0000 >=20 > pmap: Prefer consistent naming for loader tunable >=20 > The sysctl knob 'vm.pmap.pv_entry_max' becomes a loader tunable = since > 7ff48af7040f (Allow a specific setting for pv entries) but is = fetched > from system environment 'vm.pmap.pv_entries'. That is inconsistent = and The 'system environment' is misleading. I meant 'kernel environment' . Sorry for fast commit. > obscure. >=20 > This reverts 36e1b9702e21 (Correct the tunable name in the = message). >=20 > PR: 231577 > Reviewed by: jhibbits, alc, kib > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D42274 > --- > sys/arm/arm/pmap-v6.c | 4 ++-- > sys/i386/i386/pmap.c | 4 ++-- > sys/powerpc/booke/pmap.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/sys/arm/arm/pmap-v6.c b/sys/arm/arm/pmap-v6.c > index 719851432203..92e992a4b25e 100644 > --- a/sys/arm/arm/pmap-v6.c > +++ b/sys/arm/arm/pmap-v6.c > @@ -1750,7 +1750,7 @@ pmap_init(void) > */ > TUNABLE_INT_FETCH("vm.pmap.shpgperproc", &shpgperproc); > pv_entry_max =3D shpgperproc * maxproc + vm_cnt.v_page_count; > - TUNABLE_INT_FETCH("vm.pmap.pv_entries", &pv_entry_max); > + TUNABLE_INT_FETCH("vm.pmap.pv_entry_max", &pv_entry_max); > pv_entry_max =3D roundup(pv_entry_max, _NPCPV); > pv_entry_high_water =3D 9 * (pv_entry_max / 10); >=20 > @@ -3012,7 +3012,7 @@ get_pv_entry(pmap_t pmap, boolean_t try) > if (ratecheck(&lastprint, &printinterval)) > printf("Approaching the limit on PV entries, = consider " > "increasing either the vm.pmap.shpgperproc = or the " > - "vm.pmap.pv_entries tunable.\n"); > + "vm.pmap.pv_entry_max tunable.\n"); > retry: > pc =3D TAILQ_FIRST(&pmap->pm_pvchunk); > if (pc !=3D NULL) { > diff --git a/sys/i386/i386/pmap.c b/sys/i386/i386/pmap.c > index 6b839484e6c5..967ad48de460 100644 > --- a/sys/i386/i386/pmap.c > +++ b/sys/i386/i386/pmap.c > @@ -998,7 +998,7 @@ __CONCAT(PMTYPE, init)(void) > */ > TUNABLE_INT_FETCH("vm.pmap.shpgperproc", &shpgperproc); > pv_entry_max =3D shpgperproc * maxproc + vm_cnt.v_page_count; > - TUNABLE_INT_FETCH("vm.pmap.pv_entries", &pv_entry_max); > + TUNABLE_INT_FETCH("vm.pmap.pv_entry_max", &pv_entry_max); > pv_entry_max =3D roundup(pv_entry_max, _NPCPV); > pv_entry_high_water =3D 9 * (pv_entry_max / 10); >=20 > @@ -2519,7 +2519,7 @@ get_pv_entry(pmap_t pmap, boolean_t try) > if (ratecheck(&lastprint, &printinterval)) > printf("Approaching the limit on PV entries, = consider " > "increasing either the vm.pmap.shpgperproc = or the " > - "vm.pmap.pv_entries tunable.\n"); > + "vm.pmap.pv_entry_max tunable.\n"); > retry: > pc =3D TAILQ_FIRST(&pmap->pm_pvchunk); > if (pc !=3D NULL) { > diff --git a/sys/powerpc/booke/pmap.c b/sys/powerpc/booke/pmap.c > index fe6b95eda085..f41ea24cd30c 100644 > --- a/sys/powerpc/booke/pmap.c > +++ b/sys/powerpc/booke/pmap.c > @@ -1069,7 +1069,7 @@ mmu_booke_init(void) > TUNABLE_INT_FETCH("vm.pmap.shpgperproc", &shpgperproc); > pv_entry_max =3D shpgperproc * maxproc + vm_cnt.v_page_count; >=20 > - TUNABLE_INT_FETCH("vm.pmap.pv_entries", &pv_entry_max); > + TUNABLE_INT_FETCH("vm.pmap.pv_entry_max", &pv_entry_max); > pv_entry_high_water =3D 9 * (pv_entry_max / 10); >=20 > uma_zone_reserve_kva(pvzone, pv_entry_max);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?07922B4A-923A-41A3-8134-10BAF338564B>