Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 7 Mar 2004 18:52:42 -0600
From:      Alan Cox <alc@cs.rice.edu>
To:        Peter Wemm <peter@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/i386/i386 vm_machdep.c
Message-ID:  <20040308005242.GG21071@cs.rice.edu>
In-Reply-To: <200403080027.i280RXIC041557@repoman.freebsd.org>
References:  <200403080027.i280RXIC041557@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 07, 2004 at 04:27:33PM -0800, Peter Wemm wrote:
> peter       2004/03/07 16:27:33 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/i386/i386        vm_machdep.c 
>   Log:
>   Other parts of the tree do not protect calls to kmem_free() with Giant,
>   so remove it from here.  The most notable examples include vm_mmap().
>   This removes one more Giant event from exit(2).
>   
>   Revision  Changes    Path
>   1.226     +0 -2      src/sys/i386/i386/vm_machdep.c

Whether this is safe depends on whether the underlying pages need to
be unwired.  An explanation can be found in uma_large_free().
Unwiring dips into the pmap, acquiring Giant before doing so.  The
consequences would be a LOR, but not a race.

Alan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040308005242.GG21071>