Date: Sun, 14 Aug 2016 04:47:23 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@FreeBSD.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <20160814044723.GF11079@FreeBSD.org> In-Reply-To: <CAG6CVpXoAtpEva0=H-tLtJLnk2gDRo-8=0cRuV7jghXdJq8fyw@mail.gmail.com> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <CAG6CVpXoAtpEva0=H-tLtJLnk2gDRo-8=0cRuV7jghXdJq8fyw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--1RkCiX/UEfbG28Bk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting the original request to remove this, which I tend to agree: -------------------------- begin quoted text --------------------------- The svn commit mail script uses some form of 'diff -p' (or 'svn diff -x-p') to include function names at the top of each hunk. The problem is that diff gets it wrong more often than not, especially (but not only) when functions are added or renamed, or outside a funciton, or in headers, or in code that makes heavy use of macros, or in files that aren't C-like source code: shell scripts, man pages, Makefiles... All it really does is clutter up the patch and mislead the reader. --------------------------- end quoted text ---------------------------- Glen On Sat, Aug 13, 2016 at 09:39:14PM -0700, Conrad Meyer wrote: > Wait, what? Why not? This option provides useful context for > reviewing changes. >=20 > Best, > Conrad >=20 > On Sat, Aug 13, 2016 at 9:35 PM, Glen Barber <gjb@freebsd.org> wrote: > > Author: gjb > > Date: Sun Aug 14 04:35:04 2016 > > New Revision: 304070 > > URL: https://svnweb.freebsd.org/changeset/base/304070 > > > > Log: > > Do not include C function changes by default in svn commit > > email. > > > > No objection: svnadmin > > Submitted by: des > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > svnadmin/conf/mailer.conf > > > > Modified: svnadmin/conf/mailer.conf > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- svnadmin/conf/mailer.conf Sun Aug 14 04:11:36 2016 (r30406= 9) > > +++ svnadmin/conf/mailer.conf Sun Aug 14 04:35:04 2016 (r30407= 0) > > @@ -143,7 +143,7 @@ > > # This is not passed to the shell, so do not use shell metacharacters. > > # The command is split around whitespace, so if you want to include > > # whitespace in the command, then ### something ###. > > -diff =3D /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s = %(to)s > > +diff =3D /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %= (to)s > > > > # The default prefix for the Subject: header for commits. > > commit_subject_prefix =3D svn commit: > > >=20 --1RkCiX/UEfbG28Bk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXr/fbAAoJEAMUWKVHj+KTlKEP/1u+vpJnUQrFYWaIcyOWK2lU BrkyaMFah00I0ih+4rFLPAWfGSEi0Gi8EPGsv4YuTRU+yFwBXhYfnmTDGI9lSeq6 LJr826+3yDhpoJr+Ck58UVS59PhXpHSExZbrGragRg770HsbYLT1b4ufglcqOtSc ExTwBnM3FJNvI5JqtCL7ySV6xMmCHkA24iRDhQpjRv2pKGCE2qLDVXd5fBdrGnuz +SYPA0+685CPbB0Akge08bGOBX2EfcW8UC0plAhc5UB/e4LO04rXtCL7Dvzby41I YuhrUg3DZc1SBpiYzhePuSF/txfmYD+9C7wQtHFVhzzfrtFl8MHEPYVaoLSYXuvl Tf/vVQldXCTOcAw+h2VLhi6S+4ZF738z2yofZ0woEZcW+Bvr0nQL06uLOGaXS6DU 5iqy74bTtyiCIb48BVtZCfSI635hg4oLEXorHPDj72iHgQP5rC5Jpo9AgWqJ01vz CxzMiNeAoXUhh+1tCPtulplaIicy6mOZJ85kRvD08SclnMU7TpNue0OjJjzur6Ht 2Xt1nuQhhhy/+6dsiwS4145yE1HPN8IVt+pDp8m12Z9KcHSW1+HZpJ9KKfBKKLsW obBDOq7Zj0GsTZrFDRcobfyTalo+sNKZgPbUcCzefem2OcNmdYXYdgSPN12gejGh NiAqNaZOQ4PItXTf0FAa =xHml -----END PGP SIGNATURE----- --1RkCiX/UEfbG28Bk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160814044723.GF11079>