Date: Tue, 23 Nov 2021 19:09:08 +1100 From: Peter Jeremy <peter@rulingia.com> To: Konstantin Belousov <kib@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8ef0c11e7ce7 - main - nfsclient: upgrade vnode lock in VOP_OPEN()/VOP_CLOSE() if we need to flush buffers Message-ID: <YZyhpJ9TrbTpjths@server.rulingia.com> In-Reply-To: <202111161714.1AGHEtBA084291@gitrepo.freebsd.org> References: <202111161714.1AGHEtBA084291@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Hxj8mYM555kBddIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-Nov-16 17:14:55 +0000, Konstantin Belousov <kib@FreeBSD.org> wrote: > nfsclient: upgrade vnode lock in VOP_OPEN()/VOP_CLOSE() if we need to = flush buffers > =20 > VOP_FSYNC() asserts that the vnode is exclusively locked for NFS. > If we try to execute file with recently modified content, the assert is > triggered. I have a diskless arm64 system configured with swap over NFS and I'm now consistently getting a panic during shutdown. I haven't specificially confirmed that it's this commit but the content is suggestive. panic: upgrade of unlocked lock (lockmgr) nfs @ /usr/src/sys/fs/nfsclient/n= fs_clvnops.c:855 cpuid =3D 3 time =3D 1637166551 KDB: stack backtrace: db_trace_self() at db_trace_self db_trace_self_wrapper() at db_trace_self_wrapper+0x30 vpanic() at vpanic+0x178 panic() at panic+0x44 witness_upgrade() at witness_upgrade+0x104 lockmgr_upgrade() at lockmgr_upgrade+0x164 nfs_lock() at nfs_lock+0x2c vop_sigdefer() at vop_sigdefer+0x30 _vn_lock() at _vn_lock+0x54 nfs_close() at nfs_close+0xc8 vop_sigdefer() at vop_sigdefer+0x30 VOP_CLOSE_APV() at VOP_CLOSE_APV+0x2c swapdev_close() at swapdev_close+0x3c swapoff_one() at swapoff_one+0x598 sys_swapoff() at sys_swapoff+0x12c do_el0_sync() at do_el0_sync+0x498 handle_el0_sync() at handle_el0_sync+0x90 --- exception, esr 0x56000000 I presume this isn't intended. Can you suggest where I should start looking for the problem? --=20 Peter Jeremy --Hxj8mYM555kBddIP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmGcoZtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzShqg//RQMm2oSJsE4VwdVkwuhN7uYCCOF4qJPYpgBsEBkVctXPVBfs1HZ04t4k SC7DRyuqT1I2DHAKbfM/ryKft+4pbPTgcZnvoDxZJ/DMPmx54FIfckm4zuRy1Uhx urxsUWAAD+H0NnXG3ipOZIF1alEROiRqOv3UnOy44vqXSEELsvBeetdFL/QrQ2RB Fm5WK4MxVNF6cdlpCB2/9x3F5Wy+oIsN7+RzVGa01vXD03XxNsx8vGPzTiGwUuqL W2I06iJMa4HodZS/7otMJmW8cTRhI2eOHJ2e2bbXlfTl6EuymvOZUDnyHUznYiDE VIbH4foIqb7I7EOykciSfDl4aAh3PBoBtYj0q3UCojk/FkSa+0kAKP0iCrdZgKpn mC5LijOx9j14QkELMHE+hVviZUdW+EavCa3phx5S7iWvApYkYWgIBA5nJb2pGOZN aZM0eRIMd9xVkP62nt5hxGkqepkAjAWux+JjscIrZ9f9aNSVKHfKBU40TpRgli3J vg2h1mnWzg3jOQr2lggRBITKwID8IgNDGPR4T9mbfXL+uvPXrJ5LG9p9qdLkis1Z /56PZWkJHOqmOac9VB6fKgXH2OFDAitcwTtxQJXKFHNxC8SGyIuwo2r/kxWvsimn 8pYBjZAWGxspf/IypyOBbWAUWuTEh7TxCUiaaWi52Z/WYlA/Ylw= =4qID -----END PGP SIGNATURE----- --Hxj8mYM555kBddIP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZyhpJ9TrbTpjths>