Date: Fri, 20 Aug 2004 15:50:33 +0200 From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: freebsd-current@freebsd.org Subject: Re: Bogus usage of tsleep(9) in USB. Message-ID: <xzpisbdgbpy.fsf@dwp.des.no> In-Reply-To: <20040820090006.GX30151@darkness.comp.waw.pl> (Pawel Jakub Dawidek's message of "Fri, 20 Aug 2004 11:00:06 %2B0200") References: <20040820090006.GX30151@darkness.comp.waw.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek <pjd@FreeBSD.org> writes:
> There are many calls to tsleep(9) with no timeout in our USB code.
> As you all know, it is not permitted and we have KASSERT() for this:
>
> KASSERT(timo !=3D 0 || mtx_owned(&Giant) || mtx !=3D NULL,
> ("sleeping without a mutex"));
This panic message only applies to one of the three conditions the
KASSERT tests. It should probably be split into three separate
KASSERTs with three different panic messages.
DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpisbdgbpy.fsf>