Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Aug 2016 15:18:48 -0700
From:      Navdeep Parhar <np@FreeBSD.org>
To:        Stephen Hurd <shurd@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   Re: svn commit: r304704 - in stable/11/sys: conf kern net sys
Message-ID:  <7723623e-67cf-0a0a-6cba-4a3f5bdb8f16@FreeBSD.org>
In-Reply-To: <201608232121.u7NLLvDq072781@repo.freebsd.org>
References:  <201608232121.u7NLLvDq072781@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 08/23/2016 14:21, Stephen Hurd wrote:
> Author: shurd (ports committer)
> Date: Tue Aug 23 21:21:56 2016
> New Revision: 304704
> URL: https://svnweb.freebsd.org/changeset/base/304704
> 
> Log:
>   MFC r304021: Update iflib to support more NIC designs
>   
>   - Move group task queue into kern/subr_gtaskqueue.c
>   - Change intr_enable to return an int so it can be detected if it's not
>     implemented
>   - Allow different TX/RX queues per set to be different sizes
>   - Don't split up TX mbufs before transmit
>   - Allow a completion queue for TX as well as RX
>   - Pass the RX budget to isc_rxd_available() to allow an earlier return
>     and avoid multiple calls
>   
>   Approved by: sbruno
> 
> Added:
>   stable/11/sys/kern/subr_gtaskqueue.c
>      - copied unchanged from r304021, head/sys/kern/subr_gtaskqueue.c
>   stable/11/sys/sys/gtaskqueue.h
>      - copied unchanged from r304021, head/sys/sys/gtaskqueue.h
> Modified:
>   stable/11/sys/conf/files
>   stable/11/sys/kern/subr_taskqueue.c
>   stable/11/sys/net/ifdi_if.m
>   stable/11/sys/net/iflib.c
>   stable/11/sys/net/iflib.h

(I'm assuming that you do not plan to merge this to releng/11.0.)

It looks like the changes to iflib.h will break any external NIC driver
written/compiled against the iflib.h in 11.0.  Is iflib considered part
of the KPI/KBI in FreeBSD 11 or is it for in-tree use only with no
interface guarantees?  If it's the latter then why do we even have iflib
in 11.0 given that no in-tree driver in 11.0 uses it?

Regards,
Navdeep

>   stable/11/sys/sys/_task.h
>   stable/11/sys/sys/taskqueue.h
> Directory Properties:
>   stable/11/   (props changed)
> 
> ...



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7723623e-67cf-0a0a-6cba-4a3f5bdb8f16>