Date: Wed, 14 Jul 2010 11:44:57 +0200 From: Pawel Worach <pawel.worach@gmail.com> To: scsi@freebsd.org Subject: [patch] fix aicasm build with clang. Message-ID: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com>
next in thread | raw e-mail | index | archive | help
Hi,
llvm/clang as of r108260 doesn't like aicasm_gram.[c,y]
sys/dev/aic7xxx/aicasm/aicasm_gram.y:1826:51: error: use of logical || =
with constant operand; switch to bitwise | or remove constant =
[-Wlogical-bitwise-confusion]
if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || =
AIC_OP_JZ)
^ ~~~~~~~~~
Bug ?
Index: sys/dev/aic7xxx/aicasm/aicasm_gram.y
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/dev/aic7xxx/aicasm/aicasm_gram.y (revision 210025)
+++ sys/dev/aic7xxx/aicasm/aicasm_gram.y (working copy)
@@ -1823,7 +1823,7 @@
int and_op;
=20
and_op =3D FALSE;
- if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || =
AIC_OP_JZ)
+ if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || =
opcode =3D=3D AIC_OP_JZ)
and_op =3D TRUE;
=20
/*
--=20
Pawel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51186C1C-E61D-4A9D-8A78-749F48E89CE0>