Date: Thu, 23 May 2024 15:32:59 -0600 From: Warner Losh <imp@bsdimp.com> To: Brooks Davis <brooks@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a5f03413aade - main - ci: Redirect output for builds. Message-ID: <CANCZdfp6LyiZkw1fxT5wo5K9s8U6D6Xj0oHYVrJNW9=WERUF%2Bg@mail.gmail.com> In-Reply-To: <Zk-N4BNTQRcTZGOb@spindle.one-eyed-alien.net> References: <202405231800.44NI02TZ002201@gitrepo.freebsd.org> <Zk-J6aatixxTOmDJ@spindle.one-eyed-alien.net> <CANCZdfqiHXLOuH2AHXcVYmNeedb2YukJdPg8RZ9%2Bp__zZzcoDQ@mail.gmail.com> <Zk-N4BNTQRcTZGOb@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000356b0f061925cc64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2024 at 12:41=E2=80=AFPM Brooks Davis <brooks@freebsd.org> = wrote: > On Thu, May 23, 2024 at 12:34:03PM -0600, Warner Losh wrote: > > On Thu, May 23, 2024 at 12:24???PM Brooks Davis <brooks@freebsd.org> > wrote: > > > > > On Thu, May 23, 2024 at 06:00:02PM +0000, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=3Da5f03413aade8f69cf954162151da04= 3d34dd1f5 > > > > > > > > commit a5f03413aade8f69cf954162151da043d34dd1f5 > > > > Author: Warner Losh <imp@FreeBSD.org> > > > > AuthorDate: 2024-05-23 17:37:01 +0000 > > > > Commit: Warner Losh <imp@FreeBSD.org> > > > > CommitDate: 2024-05-23 17:59:40 +0000 > > > > > > > > ci: Redirect output for builds. > > > > > > > > This target is far too noisy to be at all useful. Save the > output ala > > > > make universe in _. files. Also report where to find errors. > > > > > > If this target is intended to be run in a variety CI system then this > > > won't work in practice as many have no way to preserve the contents o= f > > > the files (jenkins does with sufficient configuration, but then you > > > have to expose it to the world which is a security problem given its > > > vulnerability history.) > > > > > > > This is a developer tool to run CI before committing. It's not going to > run > > in Jenkins. If we want that, it will have to be a different target. It'= s > > way too verbose otherwise to be a useful developer tool... so verbose a= s > to > > not be at all useful. > > I think we have different take on the goal of the project that created > this target. My read was that it would move the core CI functionality > into the tree so developers could run exactly the same things jenkins > does and thus debug issues more easily. > > For reference: > https://freebsdfoundation.org/project/continuous-integration-enhancements= / Yea, I'd helped write the proposal and so maybe my perspective on this is skewing things. The goal was to run the various things that jenkins will run so you'll know whether or not you'll break Jenkins. I'm happy to revert and just go back to using make tinderbox w/o trying to do a smoke boot for landing pull requests. Warner --000000000000356b0f061925cc64 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Thu, May 23, 2024 at 12:41=E2=80= =AFPM Brooks Davis <<a href=3D"mailto:brooks@freebsd.org">brooks@freebsd= .org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1= ex">On Thu, May 23, 2024 at 12:34:03PM -0600, Warner Losh wrote:<br> > On Thu, May 23, 2024 at 12:24???PM Brooks Davis <<a href=3D"mailto:= brooks@freebsd.org" target=3D"_blank">brooks@freebsd.org</a>> wrote:<br> > <br> > > On Thu, May 23, 2024 at 06:00:02PM +0000, Warner Losh wrote:<br> > > > The branch main has been updated by imp:<br> > > ><br> > > > URL:<br> > > <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Da5f03413aade= 8f69cf954162151da043d34dd1f5" rel=3D"noreferrer" target=3D"_blank">https://= cgit.FreeBSD.org/src/commit/?id=3Da5f03413aade8f69cf954162151da043d34dd1f5<= /a><br> > > ><br> > > > commit a5f03413aade8f69cf954162151da043d34dd1f5<br> > > > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org&g= t;<br> > > > AuthorDate: 2024-05-23 17:37:01 +0000<br> > > > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org&g= t;<br> > > > CommitDate: 2024-05-23 17:59:40 +0000<br> > > ><br> > > >=C2=A0 =C2=A0 =C2=A0ci: Redirect output for builds.<br> > > ><br> > > >=C2=A0 =C2=A0 =C2=A0This target is far too noisy to be at all= useful. Save the output ala<br> > > >=C2=A0 =C2=A0 =C2=A0make universe in _. files. Also report wh= ere to find errors.<br> > ><br> > > If this target is intended to be run in a variety CI system then = this<br> > > won't work in practice as many have no way to preserve the co= ntents of<br> > > the files (jenkins does with sufficient configuration, but then y= ou<br> > > have to expose it to the world which is a security problem given = its<br> > > vulnerability history.)<br> > ><br> > <br> > This is a developer tool to run CI before committing. It's not goi= ng to run<br> > in Jenkins. If we want that, it will have to be a different target. It= 's<br> > way too verbose otherwise to be a useful developer tool... so verbose = as to<br> > not be at all useful.<br> <br> I think we have different take on the goal of the project that created<br> this target.=C2=A0 My read was that it would move the core CI functionality= <br> into the tree so developers could run exactly the same things jenkins<br> does and thus debug issues more easily.<br> <br> For reference:<br> <a href=3D"https://freebsdfoundation.org/project/continuous-integration-enh= ancements/" rel=3D"noreferrer" target=3D"_blank">https://freebsdfoundation.= org/project/continuous-integration-enhancements/</a></blockquote><div><br><= /div><div>Yea, I'd helped write the proposal and so maybe my perspectiv= e on this is</div><div>skewing things. The goal was to run the various thin= gs that jenkins will run so</div><div>you'll know whether or not you= 9;ll break Jenkins. I'm happy to revert and just=C2=A0</div><div>go bac= k to using make tinderbox w/o trying to do a smoke boot for landing pull</d= iv><div>requests.</div><div><br></div><div>Warner</div></div></div> --000000000000356b0f061925cc64--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp6LyiZkw1fxT5wo5K9s8U6D6Xj0oHYVrJNW9=WERUF%2Bg>