Date: Sat, 21 Jul 2018 10:41:48 -0600 From: Alan Somers <asomers@freebsd.org> To: Ben Woods <woodsb02@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335673 - in head: etc/defaults etc/rc.d lib/geom/eli share/man/man5 Message-ID: <CAOtMX2iynLZ=PD6EvLYShQVe0d1Fe2k6dPBk0W=uKRByPjQY7A@mail.gmail.com> In-Reply-To: <201806261807.w5QI7Hod072088@repo.freebsd.org> References: <201806261807.w5QI7Hod072088@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 26, 2018 at 12:07 PM, Ben Woods <woodsb02@freebsd.org> wrote: > Author: woodsb02 (ports committer) > Date: Tue Jun 26 18:07:16 2018 > New Revision: 335673 > URL: https://svnweb.freebsd.org/changeset/base/335673 > > Log: > geli attach multiple providers > > Allow attaching of multiple geli providers at once if they use same > passphrase and keyfiles. > > This is helpful when the providers being attached are not used for boot, > and therefore the existing code to first try the cached password when > tasting the providers during boot does not apply. > > Multiple providers with the same passphrase and keyfiles can be attached > at the same time during system start-up by adding the following to > rc.conf: > geli_groups="storage backup" > geli_storage_flags="-k /etc/geli/storage.keys" > geli_storage_devices="ada0 ada1" > geli_backup_flags="-j /etc/geli/backup.passfile -k > /etc/geli/backup.keys" > geli_backup_devices="ada2 ada3" > > Reviewed by: wblock, delphij, jilles > Approved by: sobomax (src), bcr (doc) > Differential Revision: https://reviews.freebsd.org/D12644 > > Modified: > head/etc/defaults/rc.conf > head/etc/rc.d/geli > head/lib/geom/eli/geli.8 > head/lib/geom/eli/geom_eli.c > head/share/man/man5/rc.conf.5 > It looks like this change is causing several of geli's tests to fail in CI. Could you please take a look? The failure mode is that "geli attach" exits 0 when it should fail instead. https://ci.freebsd.org/job/FreeBSD-head-amd64-test/lastCompletedBuild/testReport/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2iynLZ=PD6EvLYShQVe0d1Fe2k6dPBk0W=uKRByPjQY7A>