Date: Sat, 5 Apr 2008 19:10:02 GMT From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/122469: [patch] options for viewvc Message-ID: <200804051910.m35JA2jE011066@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/122469; it has been noted by GNATS.
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: olli hauer <ohauer@gmx.de>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/122469: [patch] options for viewvc
Date: Sat, 5 Apr 2008 15:03:04 -0400
olli hauer wrote:
> --- Makefile.orig 2008-04-03 04:39:36.000000000 +0200
> +++ Makefile 2008-04-04 09:41:51.000000000 +0200
> @@ -13,13 +13,22 @@
> MAINTAINER= pgollucci@p6m7g8.com
> COMMENT= Web-based Version Control Repository Browsing
>
> -RUN_DEPENDS= ${PYTHON_LIBDIR}/site-packages/svn/__init__.py:${PORTSDIR}/devel/subversion-python \
> - ${PYTHON_LIBDIR}/site-packages/_mysql.so:${PORTSDIR}/databases/py-MySQLdb
> +OPTIONS= MYSQL "enable experimental MYSQL support" off \
> + MODPYTHON3 "enable mod_python3 support" off
> +
> +#.include <bsd.port.pre.mk>
> +
> +RUN_DEPENDS= ${PYTHON_LIBDIR}/site-packages/svn/__init__.py:${PORTSDIR}/devel/subversion-python
>
> USE_PYTHON= yes
> .if defined (WITH_APACHE)
> USE_APACHE= 2.0+
> .endif
> +
> +.if defined(WITH_MYSQL)
> +RUN_DEPENDS+= ${PYTHON_LIBDIR}/site-packages/_mysql.so:${PORTSDIR}/databases/py-MySQLdb
> +.endif
> +
> .if defined(WITH_MODPYTHON3)
> RUN_DEPENDS+= ${APACHEMODDIR}/mod_python.so:${PORTSDIR}/www/mod_python3
> .endif
1) Needs a PORTVERSION bump, the default depends changed.
2) Also, the final include needs to change to bsd.port.post.mk
from bsd.port.mk
3) Why not move APACHE into the OPTIONS ?
4) It might be good to use WITH_APACHE2 not WITH_APACHE in this case
tough this one is my fault :)
Patch looks good otherwise though.
Please submit and updated PATCH.
Thanks.
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com)
c:703.336.9354
Consultant / http://p6m7g8.net/Resume/resume.txt
http://riderway.com / http://ridecharge.com
1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200804051910.m35JA2jE011066>