Date: Fri, 10 Oct 2014 19:17:52 +0400 From: Andrey Chernov <ache@freebsd.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-stable@freebsd.org, bapt@FreeBSD.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r270122 - in stable/10: . lib/libopie Message-ID: <5437F8A0.4080905@freebsd.org> In-Reply-To: <5437F71E.1090701@freebsd.org> References: <201408180242.s7I2gNaq087095@svn.freebsd.org> <20141010144747.GH19486@ivaldir.etoilebsd.net> <5437F373.1090300@freebsd.org> <20141011.000201.1863876266089528066.hrs@allbsd.org> <5437F71E.1090701@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 10.10.2014 19:11, Andrey Chernov wrote: > On 10.10.2014 19:02, Hiroki Sato wrote: >> ac> It is strange that nobody notice that so far. Is there any packages >> ac> which builds with libopie? If no, there is no problem. If yes, what you >> >> cyrus-sasl uses it. >> >> ac> suggest to fix, is that backing out? If yes, when exactly this change >> ac> can be merged to -stable (because -stable always stays -stable, so from >> ac> your sentence it means - never can be merged). >> >> Is it impossible to handle this by symbol versioning instead of shlib >> version bump? > > There is buffer size #define change (it was too small in unfixed > version, so discards valid input), the buffer itself is in the userland > programs, not in the library. AFAIK symbol versioning is for functions, > not for such changes but I can be wrong, I know very little about symbol > versioning procedure. From other hand, the check for buffer size is in the library, so the function which does the check can be versioned, but I still don't know how exactly to do that. -- http://ache.vniz.net/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJUN/ihAAoJEKUckv0MjfbKx7IH/R2MKGua//LOoca1QUOYk1mp cjQSOlXM2eI8l6/kWAaj3izUHpjvO5QeunmvDetyoWrSxOBB7HLPuGC22GyUl6JW FPINY8xNFcxe7nrS0MPaLrOc0jWC0dbANK+YEN0ilHtba5pTPLSHSDjEnljOGdJO lMkZkxhj2gNwTSnzoUiK+ApJCKJI2Rqb8pz37OzkylGLrmc4flKYjVOfBW6T1xpR pkGr5R1ZUsx0DBm+THhp4dy4FwhRvcv/6yosvF/kEU/OU/CR5FbR1nvNiJ8cSCLi BUzuR40ohuueGaEUjdamgcb0Y+5IkGU2XDaz5mH/Frqxp+8itCsEQlxkeWZaIss= =HU/b -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5437F8A0.4080905>