Date: Sun, 10 Apr 2016 22:23:57 -0700 From: Ravi Pokala <rpokala@mac.com> To: Sepherosa Ziehau <sephe@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297802 - head/sys/dev/hyperv/vmbus Message-ID: <0FE57290-DFEA-4524-9A46-9532643BB9FA@panasas.com> In-Reply-To: <201604110328.u3B3SI9e070348@repo.freebsd.org> References: <201604110328.u3B3SI9e070348@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi sephe, -----Original Message----- From: <owner-src-committers@freebsd.org> on behalf of Sepherosa Ziehau <sephe@FreeBSD.org> Date: 2016-04-10, Sunday at 20:28 To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: svn commit: r297802 - head/sys/dev/hyperv/vmbus >Author: sephe >Date: Mon Apr 11 03:28:17 2016 >New Revision: 297802 >URL: https://svnweb.freebsd.org/changeset/base/297802 > >Log: > hyperv: Identify Hyper-V features and recommends properly > > Features bits will be used to detect devices, e.g. timers, which > do not have corresponding event channels. > > ... > >+ op = HV_CPU_ID_FUNCTION_HV_INTERFACE; >+ do_cpuid(op, regs); >+ if (regs[0] != 0x31237648 /* HV#1 */) >+ return (false); Could you make that a #defined constant, rather than a magic integer? Thanks, Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0FE57290-DFEA-4524-9A46-9532643BB9FA>