Date: Sat, 17 Dec 2016 11:46:30 +0000 From: David Chisnall <theraven@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: "Conrad E. Meyer" <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310138 - head/lib/libc/stdio Message-ID: <00BFA847-B26A-453A-87DB-D5A55C1FAA38@FreeBSD.org> In-Reply-To: <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net> References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 16 Dec 2016, at 19:31, Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>
> Other than that, it makes more difficult to use vanilla gcc with out userland.
> and it is adding more complexity to be able to build freebsd from a non freebsd
> system which some people are working on.
Why? You’ll get some spurious warnings about printf, but that’s all. Our printf (like the glibc one) already supports user-defined extensions via register_printf_function (for which, I note, we don’t have a man page), so third-party code also has some of these warnings if they’ve registered other printf handlers.
I’d actually consider that to be the biggest argument against adding %b support: we support users adding their own interpretation of %b via register_printf_function and this will break anyone third-party code where people do this. This commit is doubly bad, because not only does it change our ABI, it doesn’t document the fact.
The code in this commit is also simply broken. It does not add a corresponding handler in xprintf.c, so as soon as someone calls register_printf_function with *any* argument, printf’s ability to handle %b will be broken in a difficult-to-debug way.
David
[-- Attachment #2 --]
0 *H
01 0 + 0 *H
00"kg}0z$F`0
*H
0u1 0 UIL10U
StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA0
160419092742Z
170419092742Z0D1 0U theraven@freebsd.org1#0! *H
theraven@freebsd.org0"0
*H
0
!htֆ [J
^=* ' :#Y6"ӊ ؊cR_0WZ=Rx4 asPm&0:P2>u=NbLn]E}$$ x S4ǖRI68RpO֔{\oz;)D=SOM^#;Ԡ*Y߆ mbf/+hBӅuQ@ڭʫ&8@Xm 00U 0 U %0++0 U 0 0 U s[Ddp = 0 U #0$l9aIF+('Hmh0o+c0a0$+0http://ocsp.startssl.com09+0-http://aia.startssl.com/certs/sca.client1.crt08U 10/0-+)'http://crl.startssl.com/sca-client1.crl0 U 0theraven@freebsd.org0#U 0http://www.startssl.com/0FU ?0=0; +70,0*+ http://www.startssl.com/policy0
*H
R1m
=.A#6n-B;w5' zGL:=E44hOaŹi}l}{f!_Fh+MD Zu!K&ECE ~PWѥftB+UcEKD&3V]g,}{-) M[_!8jJ&a͒N"jԫt2ךz0ζ=|E?<viA2W9&_u{:u۲\E00ʠk}
Q
Y0
*H
0}1 0 UIL10U
StartCom Ltd.1+0)U "Secure Digital Certificate Signing1)0'U StartCom Certification Authority0
151216010005Z
301216010005Z0u1 0 UIL10U
StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA0"0
*H
0
}â}[[_ u$Wy5 |̔
vnqY)\aL$dYG|B"QǤĩVD#'F k9O_]*ςz_kU.u3r #:C<ogT )K
Xah8v[\KqdlO)3+u7J5";[vfL/"2ϩJ# 4ד[U TB,a˖a 7H< =q d0`0U 0 U %0++0U 0 02U +0)0'%#!http://crl.startssl.com/sfsca.crl0f+Z0X0$+0http://ocsp.startssl.com00+0$http://aia.startssl.com/certs/ca.crt0 U $l9aIF+('Hmh0 U #0N @[i04hCA0?U 80604U 0,0*+ http://www.startssl.com/policy0
*H
[#'#4pnR ۡЗN⛭`]K"#H*߷Թψ;UA8 Ҟeg{ozmYE60A )wXRK6c^-Al^ k[':G=;oLv{$B5;8b,ZP4{o[-j m)[땭[4 s.c|ҴvYLJ<|ӯgu0jD2
@hl+:j\ze_ևa@HyMHINxpK?% 㤺RC:=?^&7m´) A2;E~V B1$EvcKj؝(OoپU`"$a;ҡj0$&<$ۊ+/xjzb,7}W*1ܺ tDv#8K
%^P>/i?)yRuQg^z`~sP91N0J00u1 0 UIL10U
StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA"kg}0z$F`0 + 0 *H
1 *H
0 *H
1
161217114631Z0# *H
1VQ
Th1C*^50 +7100u1 0 UIL10U
StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA"kg}0z$F`0 *H
10u1 0 UIL10U
StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA"kg}0z$F`0
*H
M?r ϕ^GҤIQ*d,.8ocZ X3`B-<8@$eiCkpL!9{x@94CmoA.6k}N
H~5G-3(7 *M"M%յ=٢Xص[q'~ Y r6 !NE<[x33K=a /ߔrm洽֬"u'"|{mJ ,-h>]ҙ
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?00BFA847-B26A-453A-87DB-D5A55C1FAA38>