Date: Sat, 21 Dec 2013 16:25:18 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Devin Teske <dteske@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com> Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts Message-ID: <37E2A444-38C0-4E8C-A2E1-5FA23B9B0FFF@fisglobal.com> In-Reply-To: <52B5BDD1.3000106@freebsd.org> References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org> <52B5AA94.3060009@freebsd.org> <DE2B2BE1-6A88-4A1C-AADA-B6308630634E@fisglobal.com> <52B5BDD1.3000106@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: > Looks great, thanks -- although you don't need the f_quietly, which > isn't defined there. >=20 > The issue is that this patch very specific to running the installer on a > video console. There are many circumstances in which it is not, in which > case this will fail (e.g. a serial console). The other thing is that the > installer should not reconfigure the host system unless it has been > explicitly asked to. It isn't always run from the install media. If you > think the default bindings for these keys don't make sense, then that > should ultimately be fixed in the console driver as well. My inspiration for this change came from a tweet in which we were (unjustly or not; doesn't matter) slammed for not having addressed this issue since it (as the person claims) first appeared in 6.x. Having felt the persons pain (and verified that, indeed, we continue to be plagued in 10) I decided to do start researching the problem in-depth. The links I posted in the commit message give an excellent view of the issue and in-fact doesn't even mention using kbdcontrol. Instead it is suggested that we create an alternate keymap that ignores the command keys. That sounds like one approach (and wins points because it is opt- in) but it doesn't solve the problem for me or anyone else running the installer. Perhaps if we had this alternate keymap in the base which does the desired thing (ignore the command keys), then we could just say that the user ought to select said keymap at the onset of the installation process. But I'm not sure *I* like that approach because then it means that for my own testing, I have to select an alternate keymap everytime I run the installer in VMware. Rather, it seems to me that the installation process, if it ignored the command key on every non-serial platform... this would be fine. Afterall, once they get the system installed, they'll have the desired keymap set and they can forget. --=20 Devin > -Nathan >=20 > On 12/21/13 10:08, Teske, Devin wrote: >> I tried to rationalize... "in what case is it actually _desirably_ >> that the >> left or right command key _should_ generate an escape sequence >> and thus cancel the existing dialog" and I couldn't think of any. >>=20 >> That being said... I'm still happy to move it. Can you have a look at the >> attached patch to see if matches what you envision? >>=20 >>=20 >> --=20 >> Devin >>=20 >>=20 >> On Dec 21, 2013, at 6:49 AM, Nathan Whitehorn wrote: >>=20 >>> Could you please revert this and move the fix to the correct place? >>> -Nathan >>>=20 >>> On 12/16/13 10:06, Nathan Whitehorn wrote: >>>> Please add this to release/rc.local instead under the console setup. >>>> There is no guarantee that "auto" is running from an environment where >>>> this is defined -- for example, it may be running from a serial >>>> console or an xterm -- and the actual installer should not be polluted >>>> with assumptions about the media from which it runs. >>>> -Nathan >>>>=20 >>>> On 12/16/13 09:50, Devin Teske wrote: >>>>> Author: dteske >>>>> Date: Mon Dec 16 15:50:59 2013 >>>>> New Revision: 259468 >>>>> URL: >> https://urldefense.proofpoint.com/v1/url?u=3Dhttp://svnweb.freebsd.org/c= hangeset/base/259468&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6vR4%2= Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DVPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3= D%0A&s=3Daed75882069cc72d4a372f6471f113be19fcb6eeeca132b424719ac3b459e2a3 >>>>>=20 >>>>> Log: >>>>> Add a fix for Long-standing problem with VMware. Described in >>>>> below links: >>>>>=20 >> https://urldefense.proofpoint.com/v1/url?u=3Dhttps://communities.vmware.= com/thread/107230&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6vR4%2Faj= 2Ns9%2FssHJjg%3D%3D%0A&m=3DVPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0= A&s=3Deb4a25314cb93209718bd46c3a142e1a92fac348d3cdf720b26f416b6061cd17 >>>>>=20 >> https://urldefense.proofpoint.com/v1/url?u=3Dhttps://communities.vmware.= com/docs/DOC-11677&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6vR4%2Fa= j2Ns9%2FssHJjg%3D%3D%0A&m=3DVPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%= 0A&s=3D2837df54aadfa9de8e081ac53a233ed2dc52f2f4a2be08ae75fefcdd4ee1ddbd >>>>> Basically, ignore the ``function 62'' and ``function 63'' >>>>> interpretations >>>>> of the left/right command key when we're in the lengthiest portion >>>>> of the >>>>> installation (initiated by the `auto' module). >>>>> The net effect is that you can now (once you've started the >>>>> installer from >>>>> the media) escape the VM without prematurely terminating the >>>>> current action >>>>> due to spurious escape sequence. >>>>> MFC after: 3 days >>>>>=20 >>>>> Modified: >>>>> head/usr.sbin/bsdinstall/scripts/auto >>>>>=20 >>>>> Modified: head/usr.sbin/bsdinstall/scripts/auto >>>>>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >>>>>=20 >>>>> --- head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:08:30 >>>>> 2013 (r259467) >>>>> +++ head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:50:59 >>>>> 2013 (r259468) >>>>> @@ -49,6 +49,10 @@ error() { >>>>> ############################################################ MAIN >>>>> +# Don't send ESC on function-key 62/63 (left/right command key) >>>>> +f_quietly kbdcontrol -f 62 '' >>>>> +f_quietly kbdcontrol -f 63 '' >>>>> + >>>>> f_dprintf "Began Installation at %s" "$( date )" >>>>> rm -rf $BSDINSTALL_TMPETC >>>>=20 >>>=20 >>=20 >> _____________ >> The information contained in this message is proprietary and/or >> confidential. If you are not the intended recipient, please: (i) >> delete the message and all copies; (ii) do not disclose, distribute or >> use the message in any manner; and (iii) notify the sender >> immediately. In addition, please be aware that any message addressed >> to our domain is subject to archiving and review by persons other than >> the intended recipient. Thank you. >=20 _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37E2A444-38C0-4E8C-A2E1-5FA23B9B0FFF>