Date: Thu, 20 Dec 2012 23:44:04 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Oliver Lehmann <oliver@freebsd.org>, Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r309264 - head/security/oidentd Message-ID: <alpine.LNX.2.00.1212202335360.2358@tuna.site> In-Reply-To: <CAF6rxgkSe6W3wQT49rrbVMxyrQOkgVw2bcv8r_4=P2xfWBiKTw@mail.gmail.com> References: <201212192025.qBJKPMJ6078702@svn.freebsd.org> <CAF6rxgkSe6W3wQT49rrbVMxyrQOkgVw2bcv8r_4=P2xfWBiKTw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 19 Dec 2012, Eitan Adler wrote:
> On 19 December 2012 15:25, Oliver Lehmann <oliver@freebsd.org> wrote:
>> +CONFIGURE_ENV+= CFLAGS="${CFLAGS} -std=gnu89"
>
> Why not
>
> USE_CSTD=gnu89 ?
First and foremost: why add CFLAGS="${CFLAGS}" to CONFIGURE_ENV?
Mk/bsd.port.mk already has the following:
if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \
CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \
:
${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}; then \
${ECHO_MSG} "===> Script \"${CONFIGURE_SCRIPT}\" failed unexpectedly."; \
And portlint warns about it as well:
WARN: Makefile: [34]: use a tab (not space) after a variable name
WARN: Makefile: CFLAGS/CXXFLAGS are not needed in CONFIGURE_ENV as they are already added there in bsd.port.mk.
Can you please fix those two?
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1212202335360.2358>