Date: Sun, 14 Mar 2010 04:29:38 -0800 From: Garrett Cooper <yanefbsd@gmail.com> To: Alexander Best <alexbestms@wwu.de> Cc: freebsd-hackers@freebsd.org, Doug Barton <dougb@freebsd.org> Subject: Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c Message-ID: <7d6fde3d1003140529y5c9c7296m7abcfd685aaa792c@mail.gmail.com> In-Reply-To: <permail-2010031412121480e26a0b00003ff3-a_best01@message-id.uni-muenster.de> References: <7d6fde3d1003132155t3059a438m80bd50fdf1dbe091@mail.gmail.com> <permail-2010031412121480e26a0b00003ff3-a_best01@message-id.uni-muenster.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 14, 2010 at 4:12 AM, Alexander Best <alexbestms@wwu.de> wrote: > Garrett Cooper schrieb am 2010-03-14: >> On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton <dougb@freebsd.org> >> wrote: >> > On 03/13/10 05:52, Alexander Best wrote: >> >> hello, > >> >> this patch fixes the following gcc warning: > >> > For all such issues, please file a PR first so it doesn't get lost. >> > When >> > you get the PR confirmation back, feel free to alert the list to >> > its >> > existence. > >> =A0 =A0Yes, please submit a proper PR for this because it's a code bug; >> FYI, your solution isn't complete though (it's close): > > ah ok. thanks for the hint. just wanted to spare linimon from dealing wit= h > such minor prs. ;) > >> ABORT(3) =A0 =A0 =A0 =A0 =A0 =A0 =A0 FreeBSD Library Functions Manual >> ABORT(3) > >> NAME >> =A0 =A0 =A0abort -- cause abnormal program termination > >> LIBRARY >> =A0 =A0 =A0Standard C Library (libc, -lc) > >> SYNOPSIS >> =A0 =A0 =A0#include <stdlib.h> > >> =A0 =A0 =A0void >> =A0 =A0 =A0abort(void); > >> =A0 =A0 Please be explicit and add stdlib.h. > > adding stdlib.h isn't going to work since stand.h is used to declare func= tion > prototypes which are also in stdlib.h. adding stdlib.h will cause gcc to > complain about multiple definitions. stand.h e.g. has it's own printf and= some > other stuff. Excellent point -- which means that any and all blanks in libstand could and should be filled in with equivalents in libc, i.e. you need to make sure that abort(3) has a proper function definition in libstand. Cheers, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d1003140529y5c9c7296m7abcfd685aaa792c>