Date: Thu, 12 Sep 2024 07:37:25 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: "Jason E. Hale" <jhale@freebsd.org> Cc: Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6b2b6fc90d27 - main - www/nghttp2: Update to 1.63.0 Message-ID: <2fd827f0194dde5a64af78a75b7303d7@mail.infomaniak.com> In-Reply-To: <CAJE75NFRM-LwWnU2k=Wj35nXPTZxquoeEAMMM5a6pWL84beeog@mail.gmail.com> References: <202409081842.488IgkEZ034994@gitrepo.freebsd.org> <6394ddba10e762464a9caeb391d10f36@mail.infomaniak.com> <CAJE75NFOoqu7dJxRubj7vxW2fZe=w=Z-5H0NrTR8UMHuEnGU8g@mail.gmail.com> <3abbf023b2b18eeaacb34d7b1616b419@mail.infomaniak.com> <CAJE75NFRM-LwWnU2k=Wj35nXPTZxquoeEAMMM5a6pWL84beeog@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-09-12T03:53:20.000+02:00, Jason E. Hale <jhale@freebsd.org> wrote: > On Wed, Sep 11, 2024 at 3:06 PM Daniel Engberg > > <daniel.engberg.lists@pyret.net> wrote: >> On 2024-09-09T11:34:49.000+02:00, Jason E. Hale >> <jhale@freebsd.org> wrote: >> >> On Sun, Sep 8, 2024 at 8:27 PM Daniel Engberg >> >> <daniel.engberg.lists@pyret.net> wrote: >> >> On 2024-09-08T20:42:46.000+02:00, Po-Chuan Hsieh >> <sunpoet@FreeBSD.org> wrote: >> >> The branch main has been updated by sunpoet: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=6b2b6fc90d270c590a53a6c84ca1df897bf95e7c >> >> commit 6b2b6fc90d270c590a53a6c84ca1df897bf95e7c >> >> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> >> AuthorDate: 2024-09-08 18:17:14 +0000 >> >> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> >> CommitDate: 2024-09-08 18:37:04 +0000 >> >> www/nghttp2: Update to 1.63.0 >> >> Hi, >> >> Both USES= compiler:c++20-lang and USE_CXXSTD= c++20 can be >> removed as no c++ code is compiled. >> >> Best regards, >> >> Daniel >> >> All of the .cc files in ${WRKSRC}/src beg to differ. >> >> - Jason >> >> Hi, >> >> They're not compiled for the library at least according to the >> build log(s). :-) >> >> CMake build: >> >> https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h00m21s/logs/libnghttp2-1.63.0.log >> >> Autotools: >> >> https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h03m47s/logs/libnghttp2-1.63.0.log >> >> Best regards, >> >> Daniel > > True, but this commit wasn't for the library, so in that context, > your > > critique seemed strange to me. > > - Jason Agreed, it was meant for libnghttp2 in the first place. I apologize. Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2024-09-12T03:53:20.000+02:00, Jason E. Hale <jhale@freebsd.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>On Wed, Sep 11, 2024 at 3:06 PM Daniel Engberg<br></div><div><<a class="defaultMailLink" href="mailto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><blockquote class="ws-ng-quote"><div> <br></div><div> On 2024-09-09T11:34:49.000+02:00, Jason E. Hale <<a class="defaultMailLink" href="mailto:jhale@freebsd.org">jhale@freebsd.org</a>> wrote:<br></div><div><br></div><div> On Sun, Sep 8, 2024 at 8:27 PM Daniel Engberg<br></div><div> <<a class="defaultMailLink" href="mailto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><div><br></div><div><br></div><div> On 2024-09-08T20:42:46.000+02:00, Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>> wrote:<br></div><div><br></div><div><br></div><div> The branch main has been updated by sunpoet:<br></div><div><br></div><div> URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=6b2b6fc90d270c590a53a6c84ca1df897bf95e7c" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=6b2b6fc90d270c590a53a6c84ca1df897bf95e7c</a><br></div><div><br></div><div>; commit 6b2b6fc90d270c590a53a6c84ca1df897bf95e7c<br></div><div> Author: Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>><br></div><div> AuthorDate: 2024-09-08 18:17:14 +0000<br></div><div> Commit: Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>><br></div><div> CommitDate: 2024-09-08 18:37:04 +0000<br></div><div><br></div><div> www/nghttp2: Update to 1.63.0<br></div><div><br></div><div><br></div><div><br></div><div><br></div><div> Hi,<br></div><div><br></div><div> Both USES= compiler:c++20-lang and USE_CXXSTD= c++20 can be removed as no c++ code is compiled.<br></div><div><br></div><div> Best regards,<br></div><div> Daniel<br></div><div><br></div><div><br></div><div> All of the .cc files in ${WRKSRC}/src beg to differ.<br></div><div><br></div><div> - Jason<br></div><div><br></div><div> Hi,<br></div><div><br></div><div> They're not compiled for the library at least according to the build log(s). :-)<br></div><div><br></div><div> CMake build:<br></div><div> <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h00m21s/logs/libnghttp2-1.63.0.log" target="_blank">https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h00m21s/logs/libnghttp2-1.63.0.log</a><br></div><div><br></div><div>; Autotools:<br></div><div> <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h03m47s/logs/libnghttp2-1.63.0.log" target="_blank">https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h03m47s/logs/libnghttp2-1.63.0.log</a><br></div><div><br></div><div>; Best regards,<br></div><div> Daniel<br></div></blockquote><div> <br></div><div>True, but this commit wasn't for the library, so in that context, your<br></div><div>critique seemed strange to me.<br></div><div><br></div><div>- Jason<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Agreed, it was meant for libnghttp2 in the first place. I apologize.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2fd827f0194dde5a64af78a75b7303d7>