Date: Sat, 14 Sep 2019 14:10:41 +1000 From: Peter Jeremy <peter@rulingia.com> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Charlie Li <ml+freebsd@vishwin.info>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline Message-ID: <20190914041041.GA97181@server.rulingia.com> In-Reply-To: <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info>
next in thread | previous in thread | raw e-mail | index | archive | help
--lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-Sep-13 16:33:15 -0400, Charlie Li <ml+freebsd@vishwin.info> wrote: >Baptiste Daroussin wrote: >> Author: bapt >> Date: Fri Sep 13 06:50:02 2019 >> New Revision: 352275 >> URL: https://svnweb.freebsd.org/changeset/base/352275 >>=20 >> Log: >> Update libedit to a snapshot from 2019-09-10 >> Reviewed by: Yuichiro Naito <naito.yuichiro_gmail.com> >> MFC after: 3 weeks >> Differential Revision: https://reviews.freebsd.org/D21584 >>=20 >I posted in phab but repeating here, this breaks the build on (at least) >aarch64: It breaks the build on arm and arm64 only. wint_t is int on all platforms: sys/sys/_types.h: typedef int __ct_rune_t; /* arg type for ctype funcs */ typedef __ct_rune_t __wint_t; /* wint_t (see above) */ but wchar_t varies between unsigned and signed: $ grep '__wchar_t' sys/*/include/_types.h=20 sys/arm/include/_types.h:typedef unsigned int ___wchar_t; sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; sys/mips/include/_types.h:typedef int ___wchar_t; sys/powerpc/include/_types.h:typedef int ___wchar_t; sys/riscv/include/_types.h:typedef int ___wchar_t; sys/sparc64/include/_types.h:typedef int ___wchar_t; sys/x86/include/_types.h:typedef int ___wchar_t; Looking back into history, it looks like the "unsigned" is part of the ARM EABI. --=20 Peter Jeremy --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl18aDxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzR7QQ//bWl+20ZdrNeDeUay1ykf8r84EmNckAIy4TEsZ8gmv6I3QuUDMwCOr8fC 132d4sFAxysXGpIln713DzZa5VCA42J2ahVjsj8LvCp/76CCsLXtcABCC5RRVoUC +akjl+ya35HvtWJyhXD3f5Vn94ULh4vqWjceb6Uqq22/ZiEJ1FA9tLAE7J/luqyK qW1o5Eomw4HJ3GkUIkpCXJq2ECTByEq3AeLo79xox75L5pwEGbFHuy00WS1KfzlC iwEB7Zo72k6ts6VQeUmnHdsTCTpqx3zwHL8oxQ11kLWZf3qn/eZdvW6ZU/BXoYCu VFOfPzmoV0/51VCukNwETNiqI9o9f7i13UZmH8CEN109UTfLPlo/OYKWO3qmnzE4 CdwEB3HOeqnmUjws/JyVKcUNORh3Dn3mvKxRcKyJkiv7LvQuksPxBD+gXjj6F26u HTsg3tgXdAjB9AlIhSgTslMDc+W7AMPi5DyGQyB+WwTDe3h3MDmuZ6ubkT2d0a4S HGHNq4YwI40OX3DvcYdx/O8fvWRrAJUvpLLqdieUK2Ajb5PTHA1aWarzfkMGkqpM i18o0DfsUgYxTCSb2Y6lG8bEV0LTf78Is8G74AH8G6bsuQVCcseE6otXqyTXVKS2 qyE6FFeSClXsamDODLdJgRHi3jxIMWD/wTdDqqrTg2d/6lCykjA= =k6ZD -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190914041041.GA97181>