Date: Wed, 14 Aug 2019 13:49:28 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: freebsd-current@freebsd.org, Ian Lepore <ian@freebsd.org>, Niclas Zeising <zeising@freebsd.org>, Emmanuel Vadot <manu@bidouilliste.com>, John Baldwin <jhb@FreeBSD.org> Cc: x11@FreeBSD.org,current@FreeBSD.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <D4F1C51E-E39D-45F6-B80E-60D483633C19@cschubert.com> In-Reply-To: <ac5725eddb2410558b825905ed248c4cba86da2d.camel@freebsd.org> References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <bee728a59abb033657a20de4e716698fb2b1c927.camel@freebsd.org> <b2951cc6-e5e8-6c14-6368-41d51f949011@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <c3a3eb30-584f-a5f1-18f7-b94a45d20dd7@FreeBSD.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> <c9ade020-92b3-2f78-ddbb-2182ea4b41d2@freebsd.org> <ac5725eddb2410558b825905ed248c4cba86da2d.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On August 14, 2019 11:04:20 AM PDT, Ian Lepore <ian@freebsd=2Eorg> wrote: >On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: >> On 2019-08-14 19:23, Emmanuel Vadot wrote: >> > On Wed, 14 Aug 2019 10:13:48 -0700 >> > John Baldwin <jhb@FreeBSD=2Eorg> wrote: >> >=20 >> > > On 8/14/19 9:22 AM, Ian Lepore wrote: >> > > > This all sounds vaguely wrong, backwards, to me=2E A developer >> > > > who is >> > > > using a given module on their build system might want that >> > > > module to be >> > > > rebuilt automatically, but only if the build parameters match >> > > > those of >> > > > the running build host system=2E >> > > >=20 >> > > > If my build host is running freebsd 12 amd64 and I'm doing a >> > > > build for >> > > > freebsd 13 armv7, I have no interest in automatic rebuilds of >> > > > an amd64 >> > > > driver module for a different OS arch and version just because >> > > > that >> > > > module happens to be installed on the system I use to do >> > > > crossbuilds=2E >> > > >=20 >> > > > My objections are theoretical=2E=2E=2E this automation just seems >> > > > improperly >> > > > designed to me=2E But it won't actually affect me in any way, >> > > > because I >> > > > don't build video driver modules from ports, and I don't run >> > > > freebsd >> > > > current on my build host machine=2E Probably the number of >> > > > people doing >> > > > crossbuilding is small enough that nobody else is going to >> > > > object to >> > > > this "the whole world is amd64" automation=2E >> > >=20 >> > > You assume DRM is amd64-only when it is definitely not=2E It also >> > > has >> > > suitable guards in its Makefile to only build the relevant kernel >> > > modules on supported architectures=2E >> >=20 >> > I clearly don't want to spend time to build the drm and radeon >> > modules >> > when I'm hacking on arm64=2E >> > Shouldn't LOCAL_MODULE have ${TARGET}=2E${TARGET_ARCH} as a >> > subdirectory ? So when you install drm-kmod-* it will only install >> > the >> > source in /usr/local/modules/${TARGET}=2E${TARGET_ARCH}/ ? (or >> > whatever >> > the correct dir is)=2E >> >=20 >>=20 >> I'm not sure what you're trying to accomplish=2E I might be=20 >> misunderstanding completely, but, at least the drm ports have >> safeguards=20 >> in their makefiles so they'll only be built for those arches where >> there=20 >> is support, and only the modules needed, as an example, i915kms=2Eko >> will=20 >> only be built on amd64 and i386, if that's what you're worried about=2E >> Regards > >I can't understand what you guys are not-understanding=2E New machinery >has been added that says "if some module source code exists in this >absolute fixed location on the build machine, then whenever you do any >kernel build for any OS version or any arch, rebuild that module source >code so that the the build machine's video drivers stay in sync with >the build machine's kernel=2E" > >Do you not see that for some of us, only a tiny fraction of the builds >done (maybe none of them at all) involve the kernel for the build host >machine or the video drivers for the build host machine? And yet, for >us, every build we do will now inapppropriately rebuild this video >driver module which has nothing to do with the machine the build is >targeting=2E > >And it's not just about crossbuilds, because it's about versions too=2E= =20 >Even when a developer is running 13-current and wants their video >driver rebuilt and installed automatically along with the kernel, >they're certainly going to want that to happen only when they're >building 13-current=2E If they're doing a test-build for 12-stable they >certainly aren't going to want to build and install that video driver=2E > >-- Ian > >_______________________________________________ >freebsd-current@freebsd=2Eorg mailing list >https://lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-current >To unsubscribe, send any mail to >"freebsd-current-unsubscribe@freebsd=2Eorg" How about build/install when arch is the same as local machine arch? --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert <Cy=2ESchubert@cschubert=2Ecom> FreeBSD UNIX: <cy@FreeBSD=2Eorg> Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4F1C51E-E39D-45F6-B80E-60D483633C19>