Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Jan 2022 08:13:10 -0800
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 17cbcf33c3b6 - main - mbuf(9): Assert receive mbufs don't carry a send tag.
Message-ID:  <YfLElqsV3yKSBb8L@FreeBSD.org>
In-Reply-To: <e45bfc10-c56c-ee1a-8b92-0be1a8d8ed17@selasky.org>
References:  <202201261242.20QCg8jX074972@gitrepo.freebsd.org> <YfIqmPWq09gz1AWJ@FreeBSD.org> <e45bfc10-c56c-ee1a-8b92-0be1a8d8ed17@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 27, 2022 at 09:29:51AM +0100, Hans Petter Selasky wrote:
H> On 1/27/22 06:16, Gleb Smirnoff wrote:
H> > Why do you allow (m == NULL) in the assertion? Does it make any sense to
H> > relax it this way?
H> 
H> Because the other M_XXXX assert macros checked for NULL aswell.

M_ASSERTPKTHDR() does absolutely the opposite - it asserts that m is present.
M_ASSERTEXTPG() doesn't check that explicitly, but also disallows (m == NULL).

-- 
Gleb Smirnoff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YfLElqsV3yKSBb8L>