Date: Sat, 17 Dec 2016 15:33:55 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310051 - in head: share/man/man9 sys/kern sys/sys Message-ID: <B3FD6271-C13E-4166-97C3-82B928A1112C@FreeBSD.org> In-Reply-To: <CABh_MK=Rxt7x0bGbJS7oRUfAowCHUWFLVp5UuWrgoqguUN%2Bzmw@mail.gmail.com> References: <201612141247.uBEClYYq008778@repo.freebsd.org> <7B04505B-6DC1-4020-BC78-D5CC0B6F6B2C@FreeBSD.org> <CABh_MK=Rxt7x0bGbJS7oRUfAowCHUWFLVp5UuWrgoqguUN%2Bzmw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
On 17 Dec 2016, at 10:43, Ed Schouten <ed@nuxi.nl> wrote:
>
> 2016-12-16 23:55 GMT+01:00 Dimitry Andric <dim@freebsd.org>:
>> Since this now causes VMware kernel modules to insta-panic the kernel,
>> it might be nice to put some warning in UPDATING, at least. Luckily
>> __FreeBSD_version got bumped by Adrian in r310149 for something
>> unrelated, but this is definitely something to notify maintainers of
>> ports (with kernel modules) about too.
>
> This change affects the KBI, as sysctl declarations now include an
> additional pointer. The underlying sysctl registration function also
> gained an additional argument. That said, if you simply rebuild all
> kernel modules, this shouldn't cause any regressions, or are you
> saying those persist? If so, this is definitely not an intended
> side-effect of this change and we should look into it.
Well, the kernel module doesn't compile anymore, of course:
os.c:894:46: error: too few arguments to function call, expected 11, have 10
BALLOON_NAME_VERBOSE);
^
/usr/src/sys/sys/sysctl.h:1014:1: note: 'sysctl_add_oid' declared here
struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist,
^
1 error generated.
I am unsure why the VMware modules don't use the SYSCTL_XXX macros.
Maybe these were not available in the past? Only the original
maintainers might know.
In any case, I have submitted a PR with a build fix, making use of the
unrelated __FreeBSD_version bump, to add an additional NULL parameter
to the call:
https://bugs.freebsd.org/215353
-Dimitry
--Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30
iEYEARECAAYFAlhVTNkACgkQsF6jCi4glqOP2QCgi4FhFa03ptYcFMeW1I1K3/8E
VdQAnikv8uUUPIHH4u0vm6DB9fHb9Qa5
=NmzV
-----END PGP SIGNATURE-----
--Apple-Mail=_51D4FED0-3271-46D4-AA9D-77860C27824A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B3FD6271-C13E-4166-97C3-82B928A1112C>