Date: Fri, 14 Jan 2005 05:28:29 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Kris Kennaway <kris@obsecurity.org>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Cc: amd64@FreeBSD.org Subject: Re: cvs commit: src/lib/msun/alpha fenv.h src/lib/msun/amd64 fenv.h src/lib/msun/arm fenv.h src/lib/msun/i387 fenv.h src/lib/msun/ia64 fenv.h src/lib/msun/powerpc fenv.h src/lib/msun/sparc64 fenv.h Message-ID: <20050114132829.GA42958@xor.obsecurity.org> In-Reply-To: <20050114132433.GA97735@VARK.MIT.EDU> References: <200501140709.j0E79NTA046894@repoman.freebsd.org> <20050114131536.GA41709@xor.obsecurity.org> <20050114132433.GA97735@VARK.MIT.EDU>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Jan 14, 2005 at 08:24:33AM -0500, David Schultz wrote: > On Fri, Jan 14, 2005, Kris Kennaway wrote: > > On Fri, Jan 14, 2005 at 07:09:23AM +0000, David Schultz wrote: > > > das 2005-01-14 07:09:23 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/msun/alpha fenv.h > > > lib/msun/amd64 fenv.h > > > lib/msun/arm fenv.h > > > lib/msun/i387 fenv.h > > > lib/msun/ia64 fenv.h > > > lib/msun/powerpc fenv.h > > > lib/msun/sparc64 fenv.h > > > Log: > > > Mark all inline asms that read the floating-point control or status > > > registers as volatile. Instructions that *wrote* to FP state were > > > already marked volatile, but apparently gcc has license to move > > > non-volatile asms past volatile asms. This broke amd64's feupdateenv > > > at -O2 due to a WAR conflict between fnstsw and fldenv there. > > > > Do you think this is likely to the cause of the build failures > > reported with a number of ports when world is compiled with -O2 > > (i.e. does the feupdateenv failure cascade to other commonly-used > > parts of the code)? > > No, this would lead to a runtime failure, and I would be surprised > if very many ports use fenv.h anyway. OK :-( Someone needs to revert amd64 back to using -O in the meantime, then. Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB58j9Wry0BWjoQKURAujtAKDEY/GK83bMoFUVqRS9rvFwSSFaigCeINV3 1kUtm2an2QXE1THaKSWLUwI= =7XcG -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050114132829.GA42958>