Date: Wed, 9 Nov 2011 09:00:32 GMT From: JD Louw <jdl.ntq@gmail.com> To: freebsd-usb@FreeBSD.org Subject: Re: usb/162307: [uslcom][patch] cp2103 usb-to-serial driver does not support modem control lines Message-ID: <201111090900.pA990Wns094378@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/162307; it has been noted by GNATS. From: JD Louw <jdl.ntq@gmail.com> To: bug-followup@FreeBSD.org, jl@nanoteq.com Cc: Subject: Re: usb/162307: [uslcom][patch] cp2103 usb-to-serial driver does not support modem control lines Date: Wed, 9 Nov 2011 10:33:47 +0200 --bcaec544f0ae90b72e04b14925bc Content-Type: multipart/alternative; boundary=bcaec544f0ae90b72b04b14925ba --bcaec544f0ae90b72b04b14925ba Content-Type: text/plain; charset=ISO-8859-1 Tested OK. Recently I came across new app note (AN571) on SiLabs's website, describing the cp210x registers in detail. Attached is another minor patch with some further cleanups: 1) Use interface no 0 (wIndex field) for all control transfers 2) Remove reserved mask on flow control. I plan on adding GPIO support later on. Should I add this as a custom IOCTL? Thanks --bcaec544f0ae90b72b04b14925ba Content-Type: text/html; charset=ISO-8859-1 Tested OK.<div><br></div><div>Recently I came across new app note (AN571) on SiLabs's website, describing the cp210x registers in detail. Attached is another minor patch with some further cleanups:</div><div><br></div> <div>1) Use interface no 0 (wIndex field) for all control transfers</div><div>2) Remove reserved mask on flow control.</div><div><br></div><div>I plan on adding GPIO support later on. Should I add this as a custom IOCTL?</div> <div><br></div><div>Thanks</div><div><br></div> --bcaec544f0ae90b72b04b14925ba-- --bcaec544f0ae90b72e04b14925bc Content-Type: text/plain; charset=US-ASCII; name="cleanup.patch.txt" Content-Disposition: attachment; filename="cleanup.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gus2238t0 LS0tIHVzbGNvbV8xXzIyLmMJMjAxMS0xMS0wNyAxOTo0NTozMS4wMDAwMDAwMDAgKzAyMDAKKysr IHVzbGNvbV8xXzIyX2ZpeF9mbG93LmMJMjAxMS0xMS0wNyAyMToyMTo0NS4wMDAwMDAwMDAgKzAy MDAKQEAgLTEwMCwxOCArMTAwLDE3IEBACiAjZGVmaW5lCVVTTENPTV9QQVJJVFlfT0RECTB4MTAK ICNkZWZpbmUJVVNMQ09NX1BBUklUWV9FVkVOCTB4MjAKIAotI2RlZmluZQlVU0xDT01fUE9SVF9O TwkJMHhGRkZGIC8qIFhYWCB0aGluayB0aGlzIHNob3VsZCBiZSAwIC0taHBzICovCisjZGVmaW5l CVVTTENPTV9QT1JUX05PCQkweDAwMDAKIAogLyogVVNMQ09NX0JSRUFLIHZhbHVlcyAqLwogI2Rl ZmluZQlVU0xDT01fQlJFQUtfT0ZGCTB4MDAKICNkZWZpbmUJVVNMQ09NX0JSRUFLX09OCQkweDAx CiAKIC8qIFVTTENPTV9TRVRfRkxPV0NUUkwgdmFsdWVzIC0gMXN0IHdvcmQgKi8KLSNkZWZpbmUJ VVNMQ09NX0ZMT1dfRFRSX09OICAgICAgMHgwMDAwMDAwMQorI2RlZmluZQlVU0xDT01fRkxPV19E VFJfT04gICAgICAweDAwMDAwMDAxIC8qIERUUiBzdGF0aWMgYWN0aXZlICovCiAjZGVmaW5lCVVT TENPTV9GTE9XX0NUU19IUyAgICAgIDB4MDAwMDAwMDggLyogQ1RTIGhhbmRzaGFrZSAqLwotI2Rl ZmluZQlVU0xDT01fRkxPV19SRVNFUlZFRCAgICAweEZGRkZGRjgwCiAvKiBVU0xDT01fU0VUX0ZM T1dDVFJMIHZhbHVlcyAtIDJuZCB3b3JkICovCi0jZGVmaW5lCVVTTENPTV9GTE9XX1JUU19PTiAg ICAgIDB4MDAwMDAwNDAKKyNkZWZpbmUJVVNMQ09NX0ZMT1dfUlRTX09OICAgICAgMHgwMDAwMDA0 MCAvKiBSVFMgc3RhdGljIGFjdGl2ZSAqLwogI2RlZmluZQlVU0xDT01fRkxPV19SVFNfSFMgICAg ICAweDAwMDAwMDgwIC8qIFJUUyBoYW5kc2hha2UgKi8KIAogZW51bSB7CkBAIC01NDAsMTQgKzUz OSwxMiBAQAogCX0KICAgICAgICAKIAlpZiAodC0+Y19jZmxhZyAmIENSVFNDVFMpIHsKLQkJZmxv d2N0cmxbMF0gPSBodG9sZTMyKFVTTENPTV9GTE9XX1JFU0VSVkVEIHwKLQkJICAgIFVTTENPTV9G TE9XX0RUUl9PTiB8IFVTTENPTV9GTE9XX0NUU19IUyk7CisJCWZsb3djdHJsWzBdID0gaHRvbGUz MihVU0xDT01fRkxPV19EVFJfT04gfCBVU0xDT01fRkxPV19DVFNfSFMpOwogCQlmbG93Y3RybFsx XSA9IGh0b2xlMzIoVVNMQ09NX0ZMT1dfUlRTX0hTKTsKIAkJZmxvd2N0cmxbMl0gPSAwOwogCQlm bG93Y3RybFszXSA9IDA7CiAJfSBlbHNlIHsKLQkJZmxvd2N0cmxbMF0gPSBodG9sZTMyKFVTTENP TV9GTE9XX1JFU0VSVkVEIHwKLQkJICAgIFVTTENPTV9GTE9XX0RUUl9PTik7CisJCWZsb3djdHJs WzBdID0gaHRvbGUzMihVU0xDT01fRkxPV19EVFJfT04pOwogCQlmbG93Y3RybFsxXSA9IGh0b2xl MzIoVVNMQ09NX0ZMT1dfUlRTX09OKTsKIAkJZmxvd2N0cmxbMl0gPSAwOwogCQlmbG93Y3RybFsz XSA9IDA7CkBAIC02OTIsNyArNjg5LDcgQEAKIAkJcmVxLmJtUmVxdWVzdFR5cGUgPSBVU0xDT01f UkVBRDsKIAkJcmVxLmJSZXF1ZXN0ID0gVVNMQ09NX1JDVFJMOwogCQlVU0VUVyhyZXEud1ZhbHVl LCAwKTsKLQkJVVNFVFcocmVxLndJbmRleCwgMCk7CisJCVVTRVRXKHJlcS53SW5kZXgsIFVTTENP TV9QT1JUX05PKTsKIAkJVVNFVFcocmVxLndMZW5ndGgsIHNpemVvZihidWYpKTsKICAgICAgICAg ICAgICAgIAogCQl1c2JkX3hmZXJfc2V0X2ZyYW1lcyh4ZmVyLCAyKTsK --bcaec544f0ae90b72e04b14925bc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201111090900.pA990Wns094378>