Date: Wed, 6 Dec 2000 15:37:19 +0100 (CET) From: Harti Brandt <brandt@fokus.gmd.de> To: hackers@freebsd.org, current@freebsd.org Subject: ATM broken in -current Message-ID: <Pine.BSF.4.21.0012061529500.402-100000@beagle.fokus.gmd.de>
next in thread | raw e-mail | index | archive | help
Hi,
the ATM stuff in /sys/dev/h{e,f}a and /sys/netatm seems to be seriously
broken in current. A simple 'atm show config' command leads to a kernel
panic. I have tracked down the problem (and had to learn, that bzero is a
function pointer rather than a function on i386).
I cannot track, how the problem was introduced, but it appears to be
somehow connected to phk's header file reorganisation in the ATM code in
october. Many of the files miss a <sys/systm.h> include and give a missing
prototyp warning for functions like splnet, printf, log, bzero...
This appears to be deadly for bzero(), because this is a function pointer
now. (I always had the fealing, that the ANSI-C syntax for calling
functions through pointers is bad ( fooptr() instead of (*fooptr)()).
Now I know why :-( ) Adding a #include <sys/systm.h> to the following
files seem to fix the problem:
dev/hea/eni_intr.c
dev/hea/eni_vcm.c
netatm/atm_if.c
netatm/atm_signal.c
netatm/atm_socket.c
netatm/atm_usrreq.c
netatm/ipatm/ipatm_event.c
netatm/ipatm/ipatm_if.c
netatm/ipatm/ipatm_load.c
netatm/ipatm/ipatm_output.c
netatm/ipatm/ipatm_vcm.c
netatm/spans/spans_cls.c
netatm/spans/spans_subr.c
netatm/uni/sscf_uni.c
netatm/uni/sscf_uni_lower.c
netatm/uni/sscf_uni_upper.c
netatm/uni/sscop.c
netatm/uni/sscop_lower.c
netatm/uni/sscop_subr.c
netatm/uni/sscop_upper.c
netatm/uni/uni_load.c
netatm/uni/uniarp_input.c
netatm/uni/uniarp_output.c
netatm/uni/uniarp_vcm.c
netatm/uni/unisig_encode.c
netatm/uni/unisig_mbuf.c
netatm/uni/unisig_msg.c
netatm/uni/unisig_print.c
netatm/uni/unisig_proto.c
netatm/uni/unisig_sigmgr_state.c
Regards,
harti
--
harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private
brandt@fokus.gmd.de, harti@begemot.org, lhbrandt@mail.ru
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0012061529500.402-100000>