Date: Sun, 25 Mar 2018 11:00:16 -0600 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331532 - head/sys/crypto/ccp Message-ID: <1521997216.49673.2.camel@freebsd.org> In-Reply-To: <201803251656.w2PGunC0061278@repo.freebsd.org> References: <201803251656.w2PGunC0061278@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2018-03-25 at 16:56 +0000, Warner Losh wrote: > Author: imp > Date: Sun Mar 25 16:56:49 2018 > New Revision: 331532 > URL: https://svnweb.freebsd.org/changeset/base/331532 > > Log: > The PNP info has to follow the module definition. Move it from just > after the array to its proper location. Otherwise, the linker.hints > file has things out of order and we associated it with whatever was > the previous module. Wow, that seems like a subtle thing that'll be easy to get wrong and hard to detect when you have. Would it be possible for the PNP macro to have some kind of reference to the structures generated by the module definition macro, to force a compile-time error if they're out of order? -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1521997216.49673.2.camel>