Date: Mon, 12 Feb 2018 08:46:43 -0600 From: Kyle Evans <kevans@freebsd.org> To: Michael Zhilin <mizhka@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, tsoome@freebsd.org, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r327058 - head/stand/efi/boot1 Message-ID: <CACNAnaHeb6JAKnO1ceK22b4ihsKpaO6Fz_7LX0DdYXLLUWLLkg@mail.gmail.com> In-Reply-To: <201712211221.vBLCLZ5p017820@repo.freebsd.org> References: <201712211221.vBLCLZ5p017820@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 21, 2017 at 6:21 AM, Michael Zhilin <mizhka@freebsd.org> wrote: > Author: mizhka > Date: Thu Dec 21 12:21:35 2017 > New Revision: 327058 > URL: https://svnweb.freebsd.org/changeset/base/327058 > > Log: > [boot/efi] scan all display modes rather than sequential try-fail way > > This patch allows to scan all display modes in boot1 as loader does. > > Before system tried to select optimal display mode by sequential scan of > modes and if error then stop scanning. This way is not good, because > if mode N is not present, mode N+1 may exist. > > In loader we use conout->Mode->MaxMode to identify maximum number of modes. > This commit is to use same way in boot1 as in loader. > > Reported by: Andrey Pustovetov <andrey.pustovetov@gmail.com> > Reviewed by: tsoome > Differential Revision: https://reviews.freebsd.org/D13541 > HI, Just FYI- we've had several reports of this doing the wrong thing for many people, most recently by Allan yesterday (IIRC). I'm going to avoid MFC'ing it, I think we should either back this out or figure out where it's going wrong sooner rather than later. =( Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHeb6JAKnO1ceK22b4ihsKpaO6Fz_7LX0DdYXLLUWLLkg>