Date: Sun, 07 Sep 2014 21:18:10 -0500 From: Alan Cox <alc@rice.edu> To: Peter Wemm <peter@wemm.org>, Alan Cox <alc@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271243 - head/sys/vm Message-ID: <540D11E2.9020804@rice.edu> In-Reply-To: <5093630.OkGduFpJtx@overcee.wemm.org> References: <201409080019.s880J4c8002174@svn.freebsd.org> <5093630.OkGduFpJtx@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/07/2014 21:14, Peter Wemm wrote:
> On Monday, September 08, 2014 12:19:04 AM Alan Cox wrote:
>
>> Log:
>> Make two functions static and eliminate an unused #define.
>
> Unfortunately, the code (and compiler) disagrees..
>
>> @@ -1504,7 +1507,7 @@ again:
>> * possibly extended). When merging, this routine may delete one or
>> * both neighbors.
>> */
>> -void
>> +static void
>> vm_map_simplify_entry(vm_map_t map, vm_map_entry_t entry)
>> {
>> vm_map_entry_t next, prev;
>
>
> sys/security/mac/mac_process.c:366:4: error: implicit declaration of
function
> 'vm_map_simplify_entry' is invalid in C99 [-Werror,-Wimplicit-function-
> declaration]
> vm_map_simplify_entry(map, vme);
>
> The code in question:
>
> static void
> mac_proc_vm_revoke_recurse(struct thread *td, struct ucred *cred,
> struct vm_map *map)
> {
> vm_map_entry_t vme;
> ...
> vm_map_simplify_entry(map, vme);
> ^^^^^^^^^^^^^^^^^^^^^^
> }
> }
> vm_map_unlock(map);
> }
>
>
Ya, I just saw that, and was rather surprised.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?540D11E2.9020804>