Date: Wed, 20 Sep 2000 11:07:44 -0700 From: Paul Saab <paul@mu.org> To: Matt Dillon <dillon@earth.backplane.com> Cc: Danny Braniss <danny@cs.huji.ac.il>, Mike Smith <msmith@FreeBSD.ORG>, freebsd-hackers@FreeBSD.ORG Subject: Re: diskless workstation Message-ID: <20000920110744.A55357@elvis.mu.org> In-Reply-To: <200009201802.e8KI2Fe45459@earth.backplane.com>; from dillon@earth.backplane.com on Wed, Sep 20, 2000 at 11:02:15AM -0700 References: <E13bfhE-00015w-00@sexta.cs.huji.ac.il> <20000920093025.A53255@elvis.mu.org> <200009201802.e8KI2Fe45459@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matt Dillon (dillon@earth.backplane.com) wrote: > A quick review of the code seems to indicate that this is indeed a bug. > As far as I can tell, the IN_CLASS*() macros assume host order. e.g. > from /usr/include/netinet/in.h: > > #define IN_CLASSA(i) (((u_int32_t)(i) & 0x80000000) == 0) > > Since s_addr is in network byte order, the conversion is necessary. If > this fixes Danny's problems, and doesn't break anyone else (Paul?), I'd > say it should be committed. After playing with it somemore, I agree.. It doesn't break for small networks, which is what I was testing on. I'll commit the fix. paul To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000920110744.A55357>