Date: Fri, 09 Sep 2016 19:02:13 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic Message-ID: <bug-211823-8-EyaifnMPr2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211823-8@https.bugs.freebsd.org/bugzilla/> References: <bug-211823-8@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823 Kirk McKusick <mckusick@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mckusick@FreeBSD.org --- Comment #7 from Kirk McKusick <mckusick@FreeBSD.org> --- Given that your value of cgp->cg_old_niblk is > 2^15 says that at least under OpenBSD the declaration of cgp->cg_old_niblk as int16_t is wrong. Rather it should be declared as uint16_t. So it seems to me that the correct solution here is to change the declaration of cgp->cg_old_niblk to be uint16_t as it should. This change should not break any existing filesystems. As to the question of compatibility of OpenBSD's UFS to that of FreeBSD, we have managed to do that so far. So, I am in favor of keeping them compatible (at least for small changes such as this one). -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211823-8-EyaifnMPr2>