Date: Wed, 24 Jul 2024 23:56:39 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 9ad171aaab0a - main - chinese/libchewing: Update to 0.8.5 Message-ID: <8cef2a2737b77aad06cc6fa1afc37b91@mail.infomaniak.com> In-Reply-To: <202407242118.46OLICR4064529@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-07-24T23:18:12.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote: > The branch main has been updated by sunpoet: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c > > commit 9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2024-07-24 21:15:47 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2024-07-24 21:15:47 +0000 > > chinese/libchewing: Update to 0.8.5 > > > > - Update WWW > > - Use complete arguments/options > > - Sort PLIST > > - Update pkg-descr > > - Take maintainership > > > > Changes: https://github.com/chewing/libchewing/releases > > --- > > chinese/libchewing/Makefile | 23 +++++++++++++---------- > > chinese/libchewing/distinfo | 6 +++--- > > chinese/libchewing/pkg-descr | 8 +++++++- > > chinese/libchewing/pkg-plist | 2 +- > > 4 files changed, 24 insertions(+), 15 deletions(-) > > diff --git a/chinese/libchewing/Makefile b/chinese/libchewing/Makefile > > index da49fb64bbad..3e4a8c7521b8 100644 > > --- a/chinese/libchewing/Makefile > > +++ b/chinese/libchewing/Makefile > > @@ -1,25 +1,28 @@ > > PORTNAME= libchewing > > -DISTVERSION= 0.8.4 > > +PORTVERSION= 0.8.5 > > CATEGORIES= chinese textproc > > -MASTER_SITES= https://github.com/chewing/${PORTNAME}/releases/download/v${DISTVERSION}/ > > +MASTER_SITES= https://github.com/chewing/libchewing/releases/download/v${PORTVERSION}/ > > > > -MAINTAINER= ports@FreeBSD.org > > +MAINTAINER= sunpoet@FreeBSD.org > > COMMENT= Chewing intelligent phonetic input method library > > -WWW= https://chewing.im > > +WWW= https://chewing.im/ \ > > + https://github.com/chewing/libchewing > > > > LICENSE= LGPL21 > > LICENSE_FILE= ${WRKSRC}/COPYING > > > > USES= cmake:testing localbase:ldflags pathfix pkgconfig sqlite tar:zst > > -USE_LDCONFIG= yes > > - > > -# Tests when running in parallel > > -# https://github.com/chewing/libchewing/issues/293 > > -CMAKE_TESTING_PARALLEL_LEVEL= 1 > > > > CMAKE_OFF= BUILD_INFO \ > > BUILD_TESTING \ > > + ENABLE_GCOV \ > > + NO_UNDEFINED \ > > + USE_VALGRIND \ > > + WITH_INTERNAL_SQLITE3 \ > > WITH_RUST > > -CMAKE_ON= WITH_SQLITE3 > > +CMAKE_ON= BUILD_SHARED_LIBS \ > > + WITH_SQLITE3 > > +CMAKE_TESTING_PARALLEL_LEVEL= 1 # https://github.com/chewing/libchewing/issues/293 > > +USE_LDCONFIG= yes > > > > .include <bsd.port.mk> [http://bsd.port.mk>]; > > diff --git a/chinese/libchewing/distinfo b/chinese/libchewing/distinfo > > index 401a80367dce..afce409cb771 100644 > > --- a/chinese/libchewing/distinfo > > +++ b/chinese/libchewing/distinfo > > @@ -1,3 +1,3 @@ > > -TIMESTAMP = 1717657425 > > -SHA256 (libchewing-0.8.4.tar.zst) = c272e85c9aff03265db08641cac25709b9faf45b4602e04ea6cb39317103b3fa > > -SIZE (libchewing-0.8.4.tar.zst) = 4967750 > > +TIMESTAMP = 1721822994 > > +SHA256 (libchewing-0.8.5.tar.zst) = 472881fc7df7f1bc90383937c504589d80d542b5f2c4c5c007017c13a21f534e > > +SIZE (libchewing-0.8.5.tar.zst) = 4969263 > > diff --git a/chinese/libchewing/pkg-descr b/chinese/libchewing/pkg-descr > > index 825f31a9af7c..97e7507cafe2 100644 > > --- a/chinese/libchewing/pkg-descr > > +++ b/chinese/libchewing/pkg-descr > > @@ -1 +1,7 @@ > > -Chewing - An Intelligent Chinese Phonetic Input Method for UNIX > > +The Chewing is an intelligent phonetic input method (Zhuyin/Bopomofo) and is one > > +of the most popular choices for Traditional Chinese users. Chewing was inspired > > +by other proprietary intelligent Zhuyin input methods on Microsoft Windows, > > +namely Wang-Xin by Eten, Microsoft New Zhuyin, and Nature Zhuyin (aka Going). > > +The Chewing developer maintains the project as a fully open-source effort, > > +positioning it as a leading libre intelligent phonetic solution among major > > +operating environments. > > diff --git a/chinese/libchewing/pkg-plist b/chinese/libchewing/pkg-plist > > index 32e8481bd0d5..61c6bc9abc80 100644 > > --- a/chinese/libchewing/pkg-plist > > +++ b/chinese/libchewing/pkg-plist > > @@ -1,6 +1,6 @@ > > +include/chewing/chewing-compat.h > > include/chewing/chewing.h > > include/chewing/chewingio.h > > -include/chewing/chewing-compat.h > > include/chewing/global.h > > include/chewing/mod_aux.h > > lib/libchewing.so [http://libchewing.so] Hi, Can you please stop doing regression to ports that goes against Porters Handbook and why add a lot of noise for options that aren't needed as in not changed from defaults? https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkgname This has been in Porters Handbook for years by now Any reason as to why NO_UNDEFINED is disabled (this seems to be a mistake)? Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2024-07-24T23:18:12.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by sunpoet:<br></div><div><br></div><div>URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c</a><br></div><div><br></div><div>commit 9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c<br></div><div>Author: Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-07-24 21:15:47 +0000<br></div><div>Commit: Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>><br></div><div>CommitDate: 2024-07-24 21:15:47 +0000<br></div><div><br></div><div> chinese/libchewing: Update to 0.8.5<br></div><div> <br></div><div> - Update WWW<br></div><div> - Use complete arguments/options<br></div><div> - Sort PLIST<br></div><div> - Update pkg-descr<br></div><div> - Take maintainership<br></div><div> <br></div><div> Changes: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/chewing/libchewing/releases" target="_blank">https://github.com/chewing/libchewing/releases</a><br></div><div>---<br></div><div>; chinese/libchewing/Makefile | 23 +++++++++++++----------<br></div><div> chinese/libchewing/distinfo | 6 +++---<br></div><div> chinese/libchewing/pkg-descr | 8 +++++++-<br></div><div> chinese/libchewing/pkg-plist | 2 +-<br></div><div> 4 files changed, 24 insertions(+), 15 deletions(-)<br></div><div><br></div><div>diff --git a/chinese/libchewing/Makefile b/chinese/libchewing/Makefile<br></div><div>index da49fb64bbad..3e4a8c7521b8 100644<br></div><div>--- a/chinese/libchewing/Makefile<br></div><div>+++ b/chinese/libchewing/Makefile<br></div><div>@@ -1,25 +1,28 @@<br></div><div> PORTNAME= libchewing<br></div><div>-DISTVERSION= 0.8.4<br></div><div>+PORTVERSION= 0.8.5<br></div><div> CATEGORIES= chinese textproc<br></div><div>-MASTER_SITES= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/chewing/" target="_blank">https://github.com/chewing/</a>${PORTNAME}/releases/download/v${DISTVERSION}/<br></div><div>+MASTER_SITES= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/chewing/libchewing/releases/download/v" target="_blank">https://github.com/chewing/libchewing/releases/download/v</a>${PORTVERSION}/<br></div><div>; <br></div><div>-MAINTAINER= <a class="defaultMailLink" href="mailto:ports@FreeBSD.org">ports@FreeBSD.org</a><br></div><div>+MAINTAINER= <a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a><br></div><div> COMMENT= Chewing intelligent phonetic input method library<br></div><div>-WWW= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://chewing.im" target="_blank">https://chewing.im</a><br></div><div>+WWW= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://chewing.im/" target="_blank">https://chewing.im/</a>; \<br></div><div>+ <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/chewing/libchewing" target="_blank">https://github.com/chewing/libchewing</a><br></div><div>; <br></div><div> LICENSE= LGPL21<br></div><div> LICENSE_FILE= ${WRKSRC}/COPYING<br></div><div> <br></div><div> USES= cmake:testing localbase:ldflags pathfix pkgconfig sqlite tar:zst<br></div><div>-USE_LDCONFIG= yes<br></div><div>-<br></div><div>-# Tests when running in parallel<br></div><div>-# <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/chewing/libchewing/issues/293" target="_blank">https://github.com/chewing/libchewing/issues/293</a><br></div><div>-CMAKE_TESTING_PARALLEL_LEVEL= 1<br></div><div> <br></div><div> CMAKE_OFF= BUILD_INFO \<br></div><div> BUILD_TESTING \<br></div><div>+ ENABLE_GCOV \<br></div><div>+ NO_UNDEFINED \<br></div><div>+ USE_VALGRIND \<br></div><div>+ WITH_INTERNAL_SQLITE3 \<br></div><div> WITH_RUST<br></div><div>-CMAKE_ON= WITH_SQLITE3<br></div><div>+CMAKE_ON= BUILD_SHARED_LIBS \<br></div><div>+ WITH_SQLITE3<br></div><div>+CMAKE_TESTING_PARALLEL_LEVEL= 1 # <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/chewing/libchewing/issues/293" target="_blank">https://github.com/chewing/libchewing/issues/293</a><br></div><div>+USE_LDCONFIG= yes<br></div><div> <br></div><div> .include <<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.mk>" target="_blank">bsd.port.mk></a>;<br></div><div>diff --git a/chinese/libchewing/distinfo b/chinese/libchewing/distinfo<br></div><div>index 401a80367dce..afce409cb771 100644<br></div><div>--- a/chinese/libchewing/distinfo<br></div><div>+++ b/chinese/libchewing/distinfo<br></div><div>@@ -1,3 +1,3 @@<br></div><div>-TIMESTAMP = 1717657425<br></div><div>-SHA256 (libchewing-0.8.4.tar.zst) = c272e85c9aff03265db08641cac25709b9faf45b4602e04ea6cb39317103b3fa<br></div><div>-SIZE (libchewing-0.8.4.tar.zst) = 4967750<br></div><div>+TIMESTAMP = 1721822994<br></div><div>+SHA256 (libchewing-0.8.5.tar.zst) = 472881fc7df7f1bc90383937c504589d80d542b5f2c4c5c007017c13a21f534e<br></div><div>+SIZE (libchewing-0.8.5.tar.zst) = 4969263<br></div><div>diff --git a/chinese/libchewing/pkg-descr b/chinese/libchewing/pkg-descr<br></div><div>index 825f31a9af7c..97e7507cafe2 100644<br></div><div>--- a/chinese/libchewing/pkg-descr<br></div><div>+++ b/chinese/libchewing/pkg-descr<br></div><div>@@ -1 +1,7 @@<br></div><div>-Chewing - An Intelligent Chinese Phonetic Input Method for UNIX<br></div><div>+The Chewing is an intelligent phonetic input method (Zhuyin/Bopomofo) and is one<br></div><div>+of the most popular choices for Traditional Chinese users. Chewing was inspired<br></div><div>+by other proprietary intelligent Zhuyin input methods on Microsoft Windows,<br></div><div>+namely Wang-Xin by Eten, Microsoft New Zhuyin, and Nature Zhuyin (aka Going).<br></div><div>+The Chewing developer maintains the project as a fully open-source effort,<br></div><div>+positioning it as a leading libre intelligent phonetic solution among major<br></div><div>+operating environments.<br></div><div>diff --git a/chinese/libchewing/pkg-plist b/chinese/libchewing/pkg-plist<br></div><div>index 32e8481bd0d5..61c6bc9abc80 100644<br></div><div>--- a/chinese/libchewing/pkg-plist<br></div><div>+++ b/chinese/libchewing/pkg-plist<br></div><div>@@ -1,6 +1,6 @@<br></div><div>+include/chewing/chewing-compat.h<br></div><div> include/chewing/chewing.h<br></div><div> include/chewing/chewingio.h<br></div><div>-include/chewing/chewing-compat.h<br></div><div> include/chewing/global.h<br></div><div> include/chewing/mod_aux.h<br></div><div> lib/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://libchewing.so" target="_blank">libchewing.so</a><br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Hi,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Can you please stop doing regression to ports that goes against Porters Handbook and why add a lot of noise for options that aren't needed as in not changed from defaults?<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkgname">https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkgname</a><br>This has been in Porters Handbook for years by now</div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Any reason as to why NO_UNDEFINED is disabled (this seems to be a mistake)?<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8cef2a2737b77aad06cc6fa1afc37b91>