Date: Thu, 29 Apr 2021 13:22:46 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Adriaan de Groot <adridg@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Please use conventional commit messages (Re: git: 2a9b7ca2a362) Message-ID: <20210429112246.aj7aciwnu7ae6eej@aching.in.mat.cc> In-Reply-To: <YIqDoKuD4UsBZVD8@FreeBSD.org> References: <202104281017.13SAHDF2019723@gitrepo.freebsd.org> <2794032.slGk94SIus@beastie.bionicmutton.org> <YIlMysgKhvtgeirW@FreeBSD.org> <20210429094556.usriaerpcgtgszwz@aching.in.mat.cc> <YIqDoKuD4UsBZVD8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--icsgugy7a2urmp3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 29, 2021 at 10:00:00AM +0000, Alexey Dokuchaev wrote: > On Thu, Apr 29, 2021 at 11:45:56AM +0200, Mathieu Arnold wrote: > > On Wed, Apr 28, 2021 at 11:53:46AM +0000, Alexey Dokuchaev wrote: > > > On Wed, Apr 28, 2021 at 12:36:39PM +0200, Adriaan de Groot wrote: > > > > On Wednesday, 28 April 2021 12:17:13 CEST Alexey Dokuchaev wrote: > > > > > commit 2a9b7ca2a3620249bfad050ac3eee6d859926213 > > > > > ... > > > > >=20 > > > > > Update `www/web2ldap' to version 1.5.117. > > > >=20 > > > > Please use conventional commit messages, [...] > > >=20 > > > I think it is conventional enough. [...] > >=20 > > The format of a commit message is documented there: [...] > >=20 > > Please follow it. >=20 > I know where it's documented; I might follow it at least for those > commits where it doesn't look as bad as it looks for others (e.g., > which covert several ports). However, I still didn't get the answer > as to why we are duplicating inferrable metainformation rather than > fixing the commit email template and/or configuring cgit properly. Well, it has nothing to do with email, it has to do with how commits are handled by Git. In Git, the first line is the subject, and then you have the body of the commit. The subject is not only about email, for example, if you run `git log --oneline`: 2d719a7528bd (HEAD -> main, origin/main, origin/HEAD) Update to 9.16.15. 92ca026aa01c dns/bind911: Update to 9.11.31. 4507e5034cf7 net/wireguard-kmod: Update to 0.0.20210428 e25cdb34606a sysutils/virtualmin: update to version 6.16. 004e688b9b43 audio/audacity Upgrade to 3.0.2 448693e731a7 www/chromium: update to 90.0.4430.93 or a more elaborate command like `git log --oneline --graph --date-order --all`: * 2d719a7528bd (HEAD -> main, origin/main, origin/HEAD) Update to 9.16.15. * 92ca026aa01c dns/bind911: Update to 9.11.31. | * 44436ff0b0c0 (origin/2021Q2, 2021Q2) Update to 9.16.15. | * b273390548ec dns/bind911: Update to 9.11.31. * | 4507e5034cf7 net/wireguard-kmod: Update to 0.0.20210428 * | e25cdb34606a sysutils/virtualmin: update to version 6.16. * | 004e688b9b43 audio/audacity Upgrade to 3.0.2 | * a7dc410fd7d0 www/chromium: update to 90.0.4430.93 | * 1e5773db640e www/chromium: mark BROKEN on 11/i386 for now | * 138633085148 www/chromium: update to 90.0.4430.85 You get only the first line, and the first line is where the most important bits have to go. --=20 Mathieu Arnold --icsgugy7a2urmp3c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmCKlwFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgL68Q//RwDLRlh8knkUasuh15Eaj0s21PUl+xZwUyDY/LmwXbzXibQ8GS1x5Q0x m5ocV7qDnVX1dnjFVh/OnOTrO6jrKcNdmUEl9T40x6PQPsFwZ0lVGz1N70ZIKt6o Cp9Gu0kLtKZqmas8MI3czMEEs18EWClKA2aYafwAI8gCvvXazC2bLTdzEAqODIHK Yjb9UV3YnEJIkDCRXyjCQjisEz/QPI5ZNSoZxKBjCnu/33oe2np35rOTHY+Fj33W zzCaDkBScxl3nAd2YxdxlwF/jhgIhaP9IAMhRjSuVyFBO+q/Icgv+AjDLGmwaVm3 wErkh9lg+j6BIwTacbvcaRrGS/HqQgRvw7i6osr0mDReIyFr4Pmx3u0lKVPR865K /JvuWZm/BCjxTozgmqOPd0DllnoESpNqihIULstCSg3nSZHe9sK8ixgE/mtDN4BI 0FphjBZUjIIpzgoVtsILenPpQ2Htk7sz87HpN9Bhx+dKQEWuukyRNkaQX5VDVIff orwv/AVNLCX0vrardthdLbZ0phAX5bBjrYpOWqjflUjbLjL4RI7MPDKktSQR/GEZ WuDHaIWJCPNpJhVjYVbMEdDSL/jcwDOyTDR0riwbRu6vx/cPKfs4RRmsaTOzzGva EttVmLw6JHO4kkvDWOoh6kfDd2qXzyC+PnJ0xNg5wIDCaN8BfhQ= =/UJ+ -----END PGP SIGNATURE----- --icsgugy7a2urmp3c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210429112246.aj7aciwnu7ae6eej>