Date: Thu, 23 Nov 2000 23:55:38 +0100 From: Marko Cuk <cuk@nu.cuk.nu> To: Bosko Milekic <bmilekic@technokratis.com>, freebsd-net@freebsd.org, tmoestl@gmx.net Subject: Re: PATCH REVIEW Re: bug in bridging/dummynet code - PR kern/19551 Message-ID: <3A1DA06A.9F46ADC9@nu.cuk.nu> References: <Pine.BSF.4.21.0011231742040.32714-100000@jehovah.technokratis.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] I'll try it tommorov in my company. I'll go to bed now :). Cuk Bosko Milekic wrote: > I built a kernel with bridging + dummynet + ipfw and tested the diff. It > seems to be fine on my end, although I haven't gotten further feedback > from Marko. > > I've committed the fix to -CURRENT. I will wait a couple of days and MFC. > I'll close two of the three PRs now (because they directly relate to this > problem) and will leave the third one (already assigned to me) to close > in the couple of days, after I MFC this and another dummynet+bridging > related fix that went into -CURRENT about a month ago. > > Once again, thanks Thomas. Thank you Luigi for the input! > > On Wed, 22 Nov 2000, Luigi Rizzo wrote: > > > > Thomas, I have looked at and reviewed your patch, and have added one > > > hunk to bridge.c, please take a look at the "almost ready for commit" > > > version here: > > > > > > http://people.FreeBSD.org/~bmilekic/dumbridge.diff > > > > sounds ok to me (modulo testing). > > > > > Basically, I don't like the fact that we have to copy the ethernet > > > header back into the mbuf for dummynet in bdg_forward(), especially since > > > we just removed it before calling bdg_forward(). But, this is no fault of > > > > this was also part of my criticism to the original changes. > > I posted a suggestion for keeping the ethernet header together with > > the mbuf when calling ether_input() (in case, define a new function > > ether_input2() if backward compatibility was a concern) to avoid > > the need for M_PREPEND, and also (probably) to save some code in > > the in the individual drivers where the ethernet splitting is > > replicated and could be centralized in ether_input2(). > > > > But this is some change that now would require a lot of work > > in touching the individual drivers. > > > > thanks Bosko and Thomas for your work > > > > cheers > > luigi > > ----------------------------------+----------------------------------------- > > Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) > > http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 > > Phone: (510) 666 2927 > > ----------------------------------+----------------------------------------- > > Regards, > Bosko Milekic > bmilekic@technokratis.com > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message [-- Attachment #2 --] 0 G *H 80 41 0 + 0 *H I0V0 0 *H 0]1 0 UBE10U GlobalSign nv-sa10U Class 1 CA1 0 UGlobalSign Class 1 CA0 001118175006Z 001219175006Z0610U cuk@nu.cuk.nu1 0 *H cuk@nu.cuk.nu00 *H 0 Dc̝ D? ҾG|9i"zƗcDS4 89ᱮǔF]*3+HVW)&o, @"Jf0߳\&_r C0A0 `HB0 U 0 U #0<`' .~si0 *H Mwϴh{[~ܘs'wOU)b* eAo/`K;g W n9?*_KSF70%Lg;e a P͈0;0# x:0 *H 0m1 0 UBE10U GlobalSign nv-sa10U Primary Class 1 CA1&0$U GlobalSign Primary Class 1 CA0 980916120000Z 040128120000Z0]1 0 UBE10U GlobalSign nv-sa10U Class 1 CA1 0 UGlobalSign Class 1 CA00 *H 0 2X>WfLBp` 6^r̪3b%/.+"b"^]iEm Cwk1ኁbdUV|)YN̸^gMIYDza05*խ-y p0n0 U 0 U <`' .~si0 U #0fZ5@ Ҹ C 0 `HB 0 U 00 *H %!K'N3 NF ~ ߕrfQQXI #h衜 <&z`5,N*rri_cqh1ry.:T;h ޘnj Mc6r5kV5d^dB<-j.:oXikaz :>VNiņ?7t0K7K1 ~] D g.p?|e1]['y](00 x70 *H 0W1 0 UBE10U GlobalSign nv-sa10U Root CA10UGlobalSign Root CA0 980915120000Z 090128120000Z0m1 0 UBE10U GlobalSign nv-sa10U Primary Class 1 CA1&0$U GlobalSign Primary Class 1 CA0"0 *H 0 5G(9#G p!RW14Wk~CyRHͼ 2nrm.w"NK BpY c NRaDyuEaVEmB=r˦``P0rwXAQƶiO6 H?֟!tdo'>KHW gS`'s4KZVs혖]J@K b1OzYg+몃5a'fBWi jnIڏA8H c0a0U 0 U fZ5@ Ҹ C 0 U #0`{fE ʉP/}4K0U 00 *H Dq2j)U>}zD֯X ǫ ih\9H!34$lJ{`ރ Au0H& 3x*˺V2n1.F'b\Z8d74r!=Kx1f5 GIo $lsw&k]*H cP2 G [ \8$H_|4c-L wv/) v7MvK)Y$Jc_TEds!100l0]1 0 UBE10U GlobalSign nv-sa10U Class 1 CA1 0 UGlobalSign Class 1 CA 0 + 0 *H 1 *H 0 *H 1 001123225538Z0# *H 1N; + DGIo 0R *H 1E0C0 *H 0*H 0+0 *H @0 *H (0 *H -LHG]pP ytX#я:>"$adТxPޮsݝ_Qě~d\ڣAoʐ)!;aF )QϣBVb Ϳ "|elns?Aw8.shelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A1DA06A.9F46ADC9>