Date: Sat, 10 Feb 2007 20:52:28 +0000 From: Ceri Davies <ceri@submonkey.net> To: Yar Tikhiy <yar@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d hostname Message-ID: <20070210205228.GE9455@submonkey.net> In-Reply-To: <200702101313.l1ADDX8m056868@repoman.freebsd.org> References: <200702101313.l1ADDX8m056868@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--+B+y8wtTXqdUj1xM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Feb 10, 2007 at 01:13:33PM +0000, Yar Tikhiy wrote:
> yar 2007-02-10 13:13:33 UTC
>=20
> FreeBSD src repository
>=20
> Modified files:
> etc/rc.d hostname=20
> Log:
> Handle the case when the admin forgot to set $hostname,
> which can happen in new installations: advise to set the
> variable and refer to rc.conf(5).
Isn't it possible for the hostname to come via DHCP? How does this
behave in that case (or rather, I can see how it behaves; is that the
right thing)?
> | @@ -58,7 +58,16 @@ hostname_start()
> | fi
> | fi
> | =20
> | - /bin/hostname ${hostname}
> | + # Have we got a hostname yet?
> | + #
> | + if [ -z "${hostname}" ]; then
> | + warn "\$hostname is not set -- see ${rcvar_manpage}."
> | + return
> | + fi
> | +
> | + # All right, it is safe to invoke hostname(1) now.
> | + #
> | + /bin/hostname "${hostname}"
> | echo "Setting hostname: `hostname`."
Are the backticks necessary here? Why don't we use ${hostname}?
Ceri
--=20
That must be wonderful! I don't understand it at all.
-- Moliere
--+B+y8wtTXqdUj1xM
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQFFzjCMocfcwTS3JF8RArHYAJ0WBq9aPWPvpBGEMIIofEenpQ9z9QCfT41R
lslhTUKQ6tKo+km8xMtiixM=
=z+Sr
-----END PGP SIGNATURE-----
--+B+y8wtTXqdUj1xM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070210205228.GE9455>