Date: Tue, 18 Mar 2003 10:55:09 +0100 From: Guido van Rooij <guido@gvr.org> To: Guy Helmer <ghelmer@palisadesys.com> Cc: audit@freebsd.org Subject: Re: /bin/sh flag NO_HISTORY Message-ID: <20030318095509.GA70239@gvr.gvr.org> In-Reply-To: <FPEBKMIFGFHCGLLKBLMMCENKCBAA.ghelmer@palisadesys.com> References: <FPEBKMIFGFHCGLLKBLMMCENKCBAA.ghelmer@palisadesys.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 17, 2003 at 02:11:53PM -0600, Guy Helmer wrote:
> --- /usr/src/bin/sh/Makefile Mon Mar 17 10:38:03 2003
> +++ Makefile Mon Mar 17 10:34:07 2003
> @@ -14,8 +14,12 @@
> # utilities of the same name are handled with the associated manpage,
> # builtin.1 in share/man/man1/.
>
> +.if !defined(NO_HISTORY)
> DPADD+= ${LIBL} ${LIBEDIT} ${LIBTERMCAP}
> LDADD+= -ll -ledit -ltermcap
> +.else
> +CFLAGS+=-DNO_HISTORY
> +.endif
Could you please do this the other way around:
.if defined(NO_HISTORY)
CFLAGS+=-DNO_HISTORY
.else
DPADD+= ${LIBL} ${LIBEDIT} ${LIBTERMCAP}
LDADD+= -ll -ledit -ltermcap
.endif
I think double negations don't add in readbility.
-Guido
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030318095509.GA70239>