Date: Tue, 4 Nov 2008 09:07:11 +0600 From: "Boris Popov" <bp@freebsd.org> To: "Attilio Rao" <attilio@freebsd.org> Cc: Yuri Pankov <yuri.pankov@gmail.com>, freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: reproducible panic with mount_smbfs Message-ID: <35ab6dd50811031907t2ecd2ddeq82187464a1bbf3c0@mail.gmail.com> In-Reply-To: <3bbf2fe10811020817g1409a38ep26c1ee8edf075201@mail.gmail.com> References: <20081102123100.GA1434@darklight.homeunix.org> <3bbf2fe10811020737g211dfb3fs54b48e4071db2393@mail.gmail.com> <3bbf2fe10811020817g1409a38ep26c1ee8edf075201@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 2, 2008 at 10:17 PM, Attilio Rao <attilio@freebsd.org> wrote: > Yuri, > could you please test this fix: > http://www.freebsd.org/~attilio/netsmb.diff This patch looks wrong to me. AFAIR, the test (LK_EXCLUSIVE && (flags & LK_CANRECURSE)) were intended to prevent situations when SMB connection can not handle multiple requests (eg, during connection setup). But I do agree, that error processing of the lock status is bogus. -- Boris Popov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35ab6dd50811031907t2ecd2ddeq82187464a1bbf3c0>