Date: Sun, 8 Jan 2017 18:25:18 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Jan Beich <jbeich@freebsd.org> Cc: "Conrad E. Meyer" <cem@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311667 - in head/sys/contrib/dev/acpica: components/namespace components/tables include Message-ID: <31477079-EE88-4D42-B006-BB8C1B061DCB@gmail.com> In-Reply-To: <20170109022400.D7E72487A@freefall.freebsd.org> References: <20170109022400.D7E72487A@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jan 8, 2017, at 18:24, Jan Beich <jbeich@freebsd.org> wrote: > > "Conrad E. Meyer" <cem@FreeBSD.org> writes: > >> +++ head/sys/contrib/dev/acpica/components/tables/tbxface.c Sun Jan 8 06:26:33 2017 (r311667) >> @@ -314,11 +314,12 @@ ACPI_EXPORT_SYMBOL (AcpiGetTableHeader) >> >> /******************************************************************************* >> * >> - * FUNCTION: AcpiGetTable >> + * FUNCTION: AcpiGetTableWithSize >> * >> * PARAMETERS: Signature - ACPI signature of needed table >> * Instance - Which instance (for SSDTs) >> * OutTable - Where the pointer to the table is returned >> + * TblSize - Size of the table >> * >> * RETURN: Status and pointer to the requested table >> * >> @@ -333,10 +334,11 @@ ACPI_EXPORT_SYMBOL (AcpiGetTableHeader) >> ******************************************************************************/ >> >> ACPI_STATUS >> -AcpiGetTable ( >> +AcpiGetTableWithSize ( > > Can you adjust ACPI_EXPORT_SYMBOL() as well? It doesn't make sense to > export AcpiGetTable() twice but compiler won't complain if you do. Depends on the compiler and the version. IIRC clang won’t, but gcc will (depending on the version). Cheers, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYcvSOAAoJEPWDqSZpMIYVEtwP/1cFjNtjU2Fp5oQrp0TGcdUg p34EM859JhAuhFdAqv7LEU66u6c0PMBqZb1nXVvs3O6MGwDig/xvAseUOJChmVkr VOZ6SGKSlkRvv4tDgypRuDYKqej2o7XGKCZW2HFQPqyOOyFfZvPbvgJusVKbvOJB vX8+jKbqt2jB3Kn8RUWJl7a2RRymDhcNHZcv3RVhHin2jNs79883Ek143dT37yxD NmMkldDI9DILxPAWxDyfVopSjgdC8HL08HO8RRH4zeqfd7eSdnrYvaD/aDOEmWZt h2z/cNTPSd8qJ83TTe3VMhCUWbYGr/z0GfWYyPRyR2wKgN79C9NoPVD+OI342uXD cjq5Xo0BEYZLOZOqG1mhV9Cvmi8WWrbMlRgMd7yBDbCiIFH4s0bRDRGEjcefglS9 Ti+Wh3R5M51RRgjJOLxs0qMSbdtXM+7qaYtOz49lQeRfrZdnlDrDu3nqjCMOUGap EyU4cihxqKLFqGS/Wj/ifq7Onx2RmHnhTzuex9godyzPdttwXRRzquukr7HFGy20 9lskFBeEgLicWjLq+wu+TmRgLt9HCYnJKp60hGunuwMZHUqJNbFKPU/fl6l1IBja U9JLBOJojteSs1zlsWltKxc6aVIYfv98dZKCIvaFydxGg0sPd2pOJSj7eKVBhW8b VwnomwcNNROiqKXsLjeD =btMk -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31477079-EE88-4D42-B006-BB8C1B061DCB>