Date: Wed, 16 Oct 2002 11:18:57 -0700 From: Luigi Rizzo <rizzo@icir.org> To: "JINMEI Tatuya / ?$B?@L@C#:H?(B" <jinmei@isl.rdc.toshiba.co.jp> Cc: Sam Leffler <sam@errno.com>, Julian Elischer <julian@elischer.org>, freebsd-arch@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: CFR: m_tag patch Message-ID: <20021016111857.A38181@carp.icir.org> In-Reply-To: <y7vadle2r78.wl@ocean.jinmei.org>; from jinmei@isl.rdc.toshiba.co.jp on Thu, Oct 17, 2002 at 03:07:07AM %2B0900 References: <Pine.BSF.4.21.0210071613260.34884-100000@InterJet.elischer.org> <18d301c26e5e$8b5c7a30$52557f42@errno.com> <y7vd6qhg0vj.wl@ocean.jinmei.org> <080101c27151$b2e92a30$52557f42@errno.com> <y7vbs5u4s5m.wl@ocean.jinmei.org> <20021016074610.C34626@carp.icir.org> <y7vadle2r78.wl@ocean.jinmei.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 17, 2002 at 03:07:07AM +0900, JINMEI Tatuya / ?$B?@L@C#:H?(B wrote:
...
> (I re-read the thread) perhaps the example in my previous message
> wasn't good (and it was at least incorrect). According to the
> discussion on the thread, we'll probably keep m_tag_cookie being 0 and
> use m_tag_id in (e.g.) ip6_output.c. So, we'll be happy if this
> convention is kept (and will be kept) at least under netinet6.
unfortunately this will not prevent code from having to check that
the m_tag_cookie actually corresponds to the value you want, to
make sure that your code does not misinterpret as own tags
generated/destined to other clients.
Am I correct, Sam ?
> > Also note that in your example the code should be conditional
> > on __FreeBSD_version and not on __FreeBSD__
>
> We (KAME) actually need __FreeBSD__, because we want to keep a single
> code base for all *BSDs (again, I know this is our local issue). But,
i know it is a minor point, but we had this discussion before
(and hit related bugs during cross builds).
__FreeBSD__ refers to the build environment, whereas __FreeBSD_version
matches the source tree you are building, and it is #defined
on all versions of FreeBSD that you care about.
So, should you have FreeBSD-specific code (hopefully as little as
possible), you should *never* use __FreeBSD__ but instead use only
__FreeBSD_version.
cheers
luigi
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021016111857.A38181>