Date: Sun, 21 May 2023 07:29:37 +0000 From: Lorenzo Salvadore <developer@lorenzosalvadore.it> To: Rene Ladan <rene@freebsd.org> Cc: Lorenzo Salvadore <salvadore@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 779e8ab2600f - main - lang/gcc12-devel: Fix enable init_array patch Message-ID: <KBqJJMDDbdgX4GN2Y9lxggMtjDbB06bg0cu-pnRi78O4uyNzC1p1OwtQJZTHkEwnYbPqj-hOLd0AHo1xj5w8OaUrrzEq6YufX6XnWKWSYQU=@lorenzosalvadore.it> In-Reply-To: <ZGju7lZe57QWvXrr@freefall.freebsd.org> References: <202305201418.34KEI8Ii081953@gitrepo.freebsd.org> <ZGju7lZe57QWvXrr@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------- Original Message ------- On Saturday, May 20th, 2023 at 6:01 PM, Rene Ladan <rene@freebsd.org> wrote= : > > > On Sat, May 20, 2023 at 02:18:08PM +0000, Lorenzo Salvadore wrote: > > > The branch main has been updated by salvadore: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D779e8ab2600fba5f045d80= a1420f9f2278daad62 > > > > commit 779e8ab2600fba5f045d80a1420f9f2278daad62 > > Author: Lorenzo Salvadore salvadore@FreeBSD.org > > AuthorDate: 2023-05-20 00:38:33 +0000 > > Commit: Lorenzo Salvadore salvadore@FreeBSD.org > > CommitDate: 2023-05-20 14:17:36 +0000 > > > > lang/gcc12-devel: Fix enable init_array patch > > > > Add an error line that was missing in case _FreeBSD_version < 1000010. > > > > Reported by: gnikl@users.sourceforge.net > > Fixes: 8c2a479977f0 lang/gcc12-devel: Enable support for .init_array an= d .fini_array > > > A bit late, but why check for FreeBSD versions that are end-of-life for a= t > least five years instead of just unconditionally enabling them? For consistency with upstream. Upstream does such kind of checks for glibc = and Solaris, so I have added a similar check for FreeBSD to increase the chance= s to have the patch merged upstream. I should probably have written it in the original commit message, I am sorr= y I have forgotten it. Anyway, if I manage to get the patch upstreamed, then = the corresponding files in the ports tree will not be needed any more, so it sh= ould not be a big deal hopefully. Cheers, Lorenzo Salvadore
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?KBqJJMDDbdgX4GN2Y9lxggMtjDbB06bg0cu-pnRi78O4uyNzC1p1OwtQJZTHkEwnYbPqj-hOLd0AHo1xj5w8OaUrrzEq6YufX6XnWKWSYQU=>