Date: Thu, 19 Mar 2020 12:09:37 +0900 From: Wanpeng Qian <wanpengqian@gmail.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: FreeBSD virtualization <freebsd-virtualization@freebsd.org> Subject: Re: bhyve: passthrough SMART info from host nvme controller Message-ID: <CANBJ%2BxTVV3gOv7%2B8Qq9Aq1PaHEo=W%2BNMuqMwZCD7uvU80NFLmA@mail.gmail.com> In-Reply-To: <20200318175901.GI4213@funkthat.com> References: <CANBJ%2BxRdvTUHV0PQeBK2y2bCWDi5idqrD-AsHCT02fWkBLzeQQ@mail.gmail.com> <20200318175901.GI4213@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Can't you do what something like pci_passthru.c does in passthru_init, > and open /dev/nvme0 in pci_nvme_init? Yes, you are correct. but that will make /dev/nvme0 keep open all the time. I just thinking when guest fire a logpage command, open the /dev/nvme0 and get the SMART info. then close /dev/nvme0. On Thu, Mar 19, 2020 at 2:59 AM John-Mark Gurney <jmg@funkthat.com> wrote: > > Wanpeng Qian wrote this message on Wed, Mar 18, 2020 at 13:05 +0900: > > But currently bhyve has Capsicum capability, I cannot > > open /dev/nvme0 within pci_nvme.c without extra code. > > (currently I just disable the Capsicum capability) > > > > any feedback? > > Can't you do what something like pci_passthru.c does in passthru_init, > and open /dev/nvme0 in pci_nvme_init? > > Or am I missing something? > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANBJ%2BxTVV3gOv7%2B8Qq9Aq1PaHEo=W%2BNMuqMwZCD7uvU80NFLmA>